SIGTERM node shutdown type #95430
Merged
SIGTERM node shutdown type #95430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
stu-elastic added :Core/Infra/Node Lifecycle 
| Pinging @elastic/es-core-infra (Team:Core/Infra) |
| Hi @stu-elastic, I've created a changelog YAML for you. |
gwbrown suggested changes Apr 24, 2023
| RESTART, | ||
| REPLACE; | ||
| REPLACE, | ||
| SIGTERM; // local version of REMOVE |
There was a problem hiding this comment.
Suggested change
| SIGTERM; // local version of REMOVE | |
| SIGTERM; // locally-initiated version of REMOVE |
Comment on lines 79 to 81
| singleNodeShutdown -> singleNodeShutdown.getType() == SingleNodeShutdownMetadata.Type.REMOVE | ||
| || singleNodeShutdown.getType() == SingleNodeShutdownMetadata.Type.SIGTERM | ||
| || singleNodeShutdown.getType() == SingleNodeShutdownMetadata.Type.REPLACE |
There was a problem hiding this comment.
Nitpick not entirely related to this PR: Can we replace this with a switch expression so that this triggers totality checks in the future?
There was a problem hiding this comment.
Can you add some transport version guards in the writeTo method of this class? We shouldn't ever be in a situation where we're in a mixed cluster with a version that doesn't understand sigterm but given how nasty serialization problems are, better safe than sorry.
…search into srvless-sigterm-type
| Updated to |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Adds the SIGTERM shutdown type which will be used for graceful shutdown in response to SIGTERM. Right now it's the same as REPLACE.