[ML] add support for xlm_roberta tokenized models #94089
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Documentation preview: |
| Pinging @elastic/ml-core (Team:ML) |
| Hi @benwtrent, I've created a changelog YAML for you. |
…rent/elasticsearch into feature/ml-add-xlm-roberta-support
| @elasticmachine update branch |
…rent/elasticsearch into feature/ml-add-xlm-roberta-support
| @elasticmachine update branch |
davidkyle added the cloud-deploy 
| @elasticmachine update branch |
| @elasticmachine update branch |
szabosteve approved these changes Jun 7, 2023
There was a problem hiding this comment.
Thanks for writing the docs for these changes! LGTM!
I've added xlm_roberta to the list of tokenization values via f0748b8, hope you don't mind.
davidkyle approved these changes Jun 13, 2023
...re/src/main/java/org/elasticsearch/xpack/core/ml/action/PutTrainedModelVocabularyAction.java Outdated Show resolved Hide resolved
| if (vocabulary.isEmpty()) { | ||
| validationException = addValidationError("[vocabulary] must not be empty", validationException); | ||
| } else { | ||
| if (scores.isEmpty() == false && scores.size() != vocabulary.size()) { |
There was a problem hiding this comment.
Suggested change
| if (scores.isEmpty() == false && scores.size() != vocabulary.size()) { | |
| if (scores.size() != vocabulary.size()) { |
| @elasticmachine update branch |
benwtrent added the auto-merge-without-approval benwtrent added a commit to elastic/eland that referenced this pull request Jun 14, 2023
This allows XLMRoberta models to be uploaded to Elasticsearch. blocked by: elastic/elasticsearch#94089
picandocodigo pushed a commit to elastic/eland that referenced this pull request Jul 11, 2023
This allows XLMRoberta models to be uploaded to Elasticsearch. blocked by: elastic/elasticsearch#94089
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Many multi-lingual and newer models use a tokenization scheme similar to sentence-piece. This PR adds support for one of those tokenization schemes, XLMRoBERTa.
The main changes are:
scoresto the vocabulary document stored, requiring that scores be the same size as the vocabulary