Skip to content

Add shard explain info to ReactiveReason about unassigned shards #88590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 164 commits into from
Apr 27, 2023
Merged

Add shard explain info to ReactiveReason about unassigned shards #88590

merged 164 commits into from
Apr 27, 2023

Conversation

@arteam
Copy link
Contributor

@arteam arteam commented Jul 18, 2022 •
edited
Loading

Add two new fields into the reactive autoscaling policy decision response.

  • unassigned_node_decisions - can_allocate and can_remain decisions for unassigned shards (limited by 5)
  • assigned_node_decisions - can_allocate and can_remain decisions decisions for assigned shards (limited by 5)
"unassigned_node_decisions": { "[MCVEOGORUQ][0]": { "can_allocate_decisions": [ { "node_id": "node1", "node_name": "", "transport_address": "0.0.0.0:1", "deciders": [ { "decider": "no_label", "decision": "NO", "explanation": "No space to allocate" } ] } ], "can_remain_decision": null } }, "assigned_node_decisions": { "[MCVEOGORUQ][0]": { "can_allocate_decisions": [], "can_remain_decision": { "node_id": "node1", "node_name": "", "transport_address": "0.0.0.0:1", "deciders": [ { "decider": "multi_throttle", "decision": "THROTTLE", "explanation": "is not active yet" }, { "decider": "multi_no", "decision": "NO", "explanation": "No multi decision" }, { "decider": "multi_yes", "decision": "YES", "explanation": "Yes multi decision" } ] } } }

Resolves #85243
@arteam arteam force-pushed the shard_allocation_explain branch from 7cc3967 to 367ea92 Compare July 18, 2022 14:48
@arteam arteam added the WIP label Jul 20, 2022
@arteam arteam force-pushed the shard_allocation_explain branch 2 times, most recently from 6accee1 to f5b4092 Compare July 21, 2022 18:28
@arteam arteam changed the title Add shard explain info to ReactiveReason about assigned and unassigned shards Add shard explain info to ReactiveReason about unassigned shards Jul 22, 2022
@arteam arteam force-pushed the shard_allocation_explain branch 2 times, most recently from 2fa6bc4 to 651bdd6 Compare July 22, 2022 09:23
arteam added 2 commits July 22, 2022 20:40
@arteam
Add shard explain info to ReactiveReason about assigned and unassigne…
976b616 
…d shards Explain shards Add AllocateUnassignedDecision to output allocation service shouldn't be null Disable the debug mode for routing allocations Run spotless
@arteam
Work on assigned shards
e7bd66f
@arteam arteam force-pushed the shard_allocation_explain branch from 6f3aa76 to e7bd66f Compare July 22, 2022 18:40
@elasticsearchmachine elasticsearchmachine changed the base branch from master to main July 22, 2022 23:04
@arteam arteam marked this pull request as ready for review July 25, 2022 13:26
@arteam arteam requested a review from fcofdez July 25, 2022 13:26
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)
@elasticsearchmachine elasticsearchmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Jul 25, 2022
@elasticsearchmachine
Copy link
Collaborator

Hi @arteam, I've created a changelog YAML for you.
fcofdez
fcofdez reviewed Jul 26, 2022
View reviewed changes
Copy link
Contributor

@fcofdez fcofdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments
fcofdez
fcofdez reviewed Jul 26, 2022
View reviewed changes
@arteam
Copy link
Contributor Author

arteam commented Feb 28, 2023

@elasticmachine update branch
@arteam
Copy link
Contributor Author

arteam commented Mar 6, 2023

@elasticmachine update branch
@arteam arteam requested review from henningandersen and removed request for henningandersen March 6, 2023 16:07
@arteam
Copy link
Contributor Author

arteam commented Apr 12, 2023

@elasticmachine update branch
@elasticmachine
Copy link
Collaborator

merge conflict between base and head
@arteam
Copy link
Contributor Author

arteam commented Apr 25, 2023

@elasticmachine update branch
@gmarouli gmarouli added v8.9.0 and removed v8.8.0 labels Apr 26, 2023
@arteam arteam requested review from henningandersen and removed request for henningandersen April 26, 2023 20:05
henningandersen
henningandersen approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@henningandersen henningandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Left 4 smaller things to address, but no need for another round unless bigger changes are mad.
@arteam arteam force-pushed the shard_allocation_explain branch from abc6741 to 448c56d Compare April 27, 2023 15:36
@arteam arteam merged commit b74db32 into elastic:main Apr 27, 2023
@arteam arteam deleted the shard_allocation_explain branch April 27, 2023 18:13
@arteam
Copy link
Contributor Author

arteam commented Apr 27, 2023

Thank you both!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed Coordination/Autoscaling >enhancement Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. v8.9.0

10 participants

@arteam @elasticsearchmachine @elasticmachine @fcofdez @henningandersen @rjernst @csoulios @mark-vieira @gmarouli @kingherc