Add deprecation check for adjacency matrix setting #77802
Conversation
We dropped the adjacency matrix max clause setting in elastic#46327 because we believe that it is no longer required. From here on out you can use the regular boolean max clause setting.
elasticmachine added the Team:Analytics 
| Pinging @elastic/es-analytics-geo (Team:Analytics) |
| static DeprecationIssue checkIndexMatrixFiltersSetting(IndexMetadata indexMetadata) { | ||
| return checkRemovedSetting(indexMetadata.getSettings(), | ||
| IndexSettings.MAX_ADJACENCY_MATRIX_FILTERS_SETTING, | ||
| "https://www.elastic.co/guide/en/elasticsearch/reference/master/migrating-8.0.html#breaking_80_settings_changes", |
There was a problem hiding this comment.
This needs to be a link to our 7.x documentation. Maybe https://www.elastic.co/guide/en/elasticsearch/reference/7.15/search-aggregations-bucket-adjacency-matrix-aggregation.html#adjacency-matrix-agg-filter-limits? (related, i just noticed that that link says "this setting is deprecated and will be repaced").
There was a problem hiding this comment.
I think that sentence is accurate from the perspective of 7.x. You can still specify the setting in 7.x and we'll respect it. But we won't in 8.0. Should it say "this setting will be ignored in 8.0. Use indices.query.bool.max_clause_count instead." Or something like that?
All of the links above are to the 8.0 breaking changes. Are they also wrong?
There was a problem hiding this comment.
The wording sounds good to me. I've fixed all the other links that were pointing to 8.0 documentation in the last week. We're actually now using shortened URLs that can be repointed to wherever the docs team wants them without a code change (https://ela.st). If you want to change this URL to "https://ela.st/es-deprecation-7-adjacency-matrix-filters-setting" and let the docs team know where to point that, that would work.
| @masseyke I've updated the message and url. |
| @elasticmachine update branch |
4 participants
We dropped the adjacency matrix max clause setting in #46327 because we
believe that it is no longer required. From here on out you can use the
regular boolean max clause setting.