[Rest API Compatibility] Typed endpoints for Put and Get Mapping and get field mappings #71721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
| Pinging @elastic/es-core-infra (Team:Core/Infra) |
pgomulka changed the title 
Contributor Author
| once again, this PR includes a testing changes which will be removed later. I will merge them on a separate PR earlier. Feel free to ignore them. |
romseygeek approved these changes Apr 26, 2021
Contributor
romseygeek left a comment
romseygeek left a comment There was a problem hiding this comment.
I can't comment on the test rewrite code but LGTM from the mappings point of view.
joegallo reviewed Apr 26, 2021
| import org.gradle.api.tasks.Internal; | ||
| | ||
| /** | ||
| * A transformation to replace the value of a match. For example, change from "match":{"_type": "foo"} to "match":{"_type": "bar"} |
Contributor
There was a problem hiding this comment.
I think the docstring here is not accurate.
Contributor Author
There was a problem hiding this comment.
yes, I submited a separate PR for testing part here #72156
66 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Implements a V7 compatible typed endpoints for REST put and get mapping endpoints. Also for Get Field Mappings endpoints.
retrofits the REST layer change removed in #41676
relates main meta issue #51816
relates types removal issue #54160