Skip to content

Mappings get put and get mappings #58426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 80 commits into from
Jul 14, 2020
Merged

Mappings get put and get mappings #58426

merged 80 commits into from
Jul 14, 2020

Conversation

@pgomulka
Copy link
Contributor

@pgomulka pgomulka commented Jun 23, 2020 •
edited
Loading

based on pgomulka:compat/delete_update #58246

CompatRestIT. test {yaml=indices.get_field_mapping/30_missing_type/Raise 404 when type doesn't exist}

because of that change (custom type to _doc) a test that was expecting 404 for a type that did not exist, passes now as the logic is trying to fetch for _doc (any type that exist on that index will be good).

CompatRestIT. test {yaml=indices.get_mapping/11_basic_with_types/Get /{index}/_mapping with empty mappings}

this is because I can't tell if the mapping contained a type or not when fetching a mapping.

CompatRestIT. test {yaml=indices.get_mapping/20_missing_type/Existent and non-existent type returns 404 and the existing type} CompatRestIT. test {yaml=indices.get_mapping/20_missing_type/Existent and non-existent types returns 404 and the existing type} CompatRestIT. test {yaml=indices.get_mapping/20_missing_type/No type matching pattern returns 404} CompatRestIT. test {yaml=indices.get_mapping/20_missing_type/Non-existent type returns 404}

failing - (not returning 404) - because type is always found (defaulted to _doc)

CompatRestIT. test {yaml=indices.get_mapping/20_missing_type/Type missing when no types exist} CompatRestIT. test {yaml=indices.get_mapping/61_empty_with_types/Check empty mapping when getting all mappings via /_mapping} CompatRestIT. test {yaml=indices.get_template/11_basic_with_types/Get template with no mappings} CompatRestIT. test {yaml=indices.get_template/11_basic_with_types/Get template} CompatRestIT. test {yaml=indices.put_mapping/20_mix_typeless_typeful/PUT mapping with _doc on an index that has types} CompatRestIT. test {yaml=indices.put_mapping/20_mix_typeless_typeful/PUT mapping with typeless API on an index that has types}

#47364
#41676
pgomulka added 30 commits March 25, 2020 16:38
@pgomulka
init work. 221 vs 231 failing
96ebb5c 
fixed get/index tests CompatRestIT. test {yaml=get/21_stored_fields_with_types/Stored fields} CompatRestIT. test {yaml=get/71_source_filtering_with_types/Source filtering} CompatRestIT. test {yaml=index/70_mix_typeless_typeful/Index call that introduces new field mappings} CompatRestIT. test {yaml=index/70_mix_typeless_typeful/Index with typeless API on an index that has types} however the last one from get is still failing CompatRestIT. test {yaml=get/100_mix_typeless_typeful/GET with typeless API on an index that has
@pgomulka
allow registering multiple rest actions under the same path
2e922bf
@pgomulka
revert out dirs
e7eda97
@pgomulka
Merge branch 'compat_rest_api' into compat/create_index_include_type
5dac4b9
@pgomulka
extend restcreateindexaction
a213e6c
@pgomulka
code style and discovery nodes in indexaction
f1ad677
@pgomulka
fix double registration
8ff3463
@pgomulka
add search action v7
9b8a26a
@pgomulka
search & multisearch
b0a12bd
@pgomulka
types with consumer
b94be5c
@pgomulka
cleanup type funciton
f78e021
@pgomulka
packages fixed
9eb1c68
@pgomulka
update by query, delete by query, multi term and term
a421d56
@pgomulka
package rename
3364141
@pgomulka
spotless
8abcc0a
@pgomulka
checkstyle
6efdb30
@pgomulka
fake request build iwth compat
90c37e2
@pgomulka
fixing some tests
484e4ac
@pgomulka
term vector body not finished
6184a9d
@pgomulka
additional testing and using version
1ee4487
@pgomulka
unused method
abe1d28
@pgomulka
method handlers - returning null when no handler under a method was r…
d8fc2e5 
…egistered
@pgomulka
comments
d998555
@pgomulka
remove unused constant
ec8df43
@pgomulka
Merge branch 'compat_rest_api' into compat/create_index_include_type
8602f65
@pgomulka
fix javadoc
f3d25e0
@pgomulka
compile
7024913
@pgomulka
Merge branch 'compat/create_index_include_type' into compat/search
446c114
@pgomulka
spotless
cafee2f
@pgomulka
spotless
f52dbc1
@pgomulka pgomulka changed the title WIP mappings get put and get fields WIP mappings get put and get mappings Jul 8, 2020
@pgomulka
Copy link
Contributor Author

pgomulka commented Jul 9, 2020 •
edited
Loading

Test Summary
1312
tests

152
failures

19
ignored

11m50.34s
duration

88%
successful

Failed tests
Ignored tests
Packages
Classes
CompatRestIT. test {yaml=bulk/11_basic_with_types/Array of objects}
CompatRestIT. test {yaml=bulk/11_basic_with_types/Empty _id with op_type create}
CompatRestIT. test {yaml=bulk/11_basic_with_types/Empty _id}
CompatRestIT. test {yaml=bulk/11_basic_with_types/empty action}
CompatRestIT. test {yaml=bulk/21_list_of_strings_with_types/List of strings}
CompatRestIT. test {yaml=bulk/31_big_string_with_types/One big string}
CompatRestIT. test {yaml=bulk/41_source_with_types/Source filtering}
CompatRestIT. test {yaml=bulk/51_refresh_with_types/refresh=empty string immediately makes changes are visible in search}
CompatRestIT. test {yaml=bulk/51_refresh_with_types/refresh=true immediately makes changes are visible in search}
CompatRestIT. test {yaml=bulk/51_refresh_with_types/refresh=wait_for waits until changes are visible in search}
CompatRestIT. test {yaml=bulk/81_cas_with_types/Compare And Swap Sequence Numbers}
CompatRestIT. test {yaml=cat.recovery/10_basic/Test cat recovery output for closed index}
CompatRestIT. test {yaml=cat.recovery/10_basic/Test cat recovery output}
CompatRestIT. test {yaml=cat.shards/10_basic/Help}
CompatRestIT. test {yaml=cat.snapshots/10_basic/Help}
CompatRestIT. test {yaml=cat.snapshots/10_basic/Test cat snapshots output}
CompatRestIT. test {yaml=cluster.voting_config_exclusions/10_basic/Throw exception when adding voting config exclusion and specifying both node_ids and node_names}
CompatRestIT. test {yaml=cluster.voting_config_exclusions/10_basic/Throw exception when adding voting config exclusion without specifying nodes}
CompatRestIT. test {yaml=count/11_basic_with_types/count with body}
CompatRestIT. test {yaml=count/11_basic_with_types/count with empty body}
CompatRestIT. test {yaml=create/71_nested_with_types/Indexing a doc with No. nested objects more than index.mapping.nested_objects.limit should fail}
CompatRestIT. test {yaml=delete/70_mix_typeless_typeful/DELETE with typeless API on an index that has types}
CompatRestIT. test {yaml=explain/10_basic/Basic explain with alias}
CompatRestIT. test {yaml=explain/10_basic/Basic explain}
CompatRestIT. test {yaml=explain/11_basic_with_types/Basic explain with alias}
CompatRestIT. test {yaml=explain/11_basic_with_types/Basic explain}
CompatRestIT. test {yaml=explain/20_source_filtering/Source filtering}
CompatRestIT. test {yaml=explain/21_source_filtering_with_types/Source filtering}
CompatRestIT. test {yaml=explain/31_query_string_with_types/explain with query_string parameters}
CompatRestIT. test {yaml=explain/40_mix_typeless_typeful/Explain with typeless API on an index that has types}
CompatRestIT. test {yaml=get/100_mix_typeless_typeful/GET with typeless API on an index that has types}
CompatRestIT. test {yaml=get_source/11_basic_with_types/Basic with types}
CompatRestIT. test {yaml=get_source/16_default_values_with_types/Default values}
CompatRestIT. test {yaml=get_source/41_routing_with_types/Routing}
CompatRestIT. test {yaml=get_source/61_realtime_refresh_with_types/Realtime}
CompatRestIT. test {yaml=get_source/71_source_filtering_with_types/Source filtering}
CompatRestIT. test {yaml=get_source/81_missing_with_types/Missing document with catch}
CompatRestIT. test {yaml=get_source/81_missing_with_types/Missing document with ignore}
CompatRestIT. test {yaml=get_source/86_source_missing_with_types/Missing document source with catch}
CompatRestIT. test {yaml=get_source/86_source_missing_with_types/Missing document source with ignore}
CompatRestIT. test {yaml=indices.create/10_basic/Create index with explicit _doc type}
CompatRestIT. test {yaml=indices.create/10_basic/Create index without soft deletes}
CompatRestIT. test {yaml=indices.create/11_basic_with_types/Create index with aliases}
CompatRestIT. test {yaml=indices.create/11_basic_with_types/Create index with mappings}
CompatRestIT. test {yaml=indices.create/11_basic_with_types/Create index with no type mappings}
CompatRestIT. test {yaml=indices.create/11_basic_with_types/Create index with settings}
CompatRestIT. test {yaml=indices.create/11_basic_with_types/Create index with wait_for_active_shards set to all}
CompatRestIT. test {yaml=indices.create/11_basic_with_types/Create index with write aliases}
CompatRestIT. test {yaml=indices.create/11_basic_with_types/Create index}
CompatRestIT. test {yaml=indices.create/20_mix_typeless_typeful/Create a typed index while there is a typeless template}
CompatRestIT. test {yaml=indices.create/20_mix_typeless_typeful/Create a typeless index while there is a typed template}
CompatRestIT. test {yaml=indices.create/20_mix_typeless_typeful/Implicitly create a typed index while there is a typeless template}
CompatRestIT. test {yaml=indices.create/20_mix_typeless_typeful/Implicitly create a typeless index while there is a typed template}
CompatRestIT. test {yaml=indices.data_stream/10_basic/Create data stream with invalid name}
CompatRestIT. test {yaml=indices.data_stream/10_basic/Create data stream}
CompatRestIT. test {yaml=indices.data_stream/10_basic/Delete data stream with backing indices}
CompatRestIT. test {yaml=indices.data_stream/10_basic/Get data stream}
CompatRestIT. test {yaml=indices.data_stream/10_basic/Indexing a document into a data stream without a timestamp field}
CompatRestIT. test {yaml=indices.data_stream/10_basic/append-only writes to backing indices prohobited}
CompatRestIT. test {yaml=indices.data_stream/20_unsupported_apis/Test apis that do not supported data streams}
CompatRestIT. test {yaml=indices.data_stream/30_auto_create_data_stream/Put index template}
CompatRestIT. test {yaml=indices.data_stream/40_supported_apis/Verify get index api}
CompatRestIT. test {yaml=indices.data_stream/40_supported_apis/Verify get mapping api}
CompatRestIT. test {yaml=indices.delete/20_backing_indices/Attempt to delete write index on data stream is rejected}
CompatRestIT. test {yaml=indices.delete/20_backing_indices/Delete backing index on data stream}
CompatRestIT. test {yaml=indices.flush/10_basic/Index synced flush rest test}
CompatRestIT. test {yaml=indices.forcemerge/10_basic/Check deprecation warning when incompatible only_expunge_deletes and max_num_segments values are both set}
CompatRestIT. test {yaml=indices.get/11_basic_with_types/Test include_type_name}
CompatRestIT. test {yaml=indices.get/20_backing_indices/Get backing indices for data stream}
CompatRestIT. test {yaml=indices.get_field_mapping/30_missing_type/Raise 404 when type doesn't exist}
CompatRestIT. test {yaml=indices.get_field_mapping/60_data_streams/Data streams}
CompatRestIT. test {yaml=indices.get_mapping/11_basic_with_types/Get /{index}/_mapping with empty mappings}
CompatRestIT. test {yaml=indices.get_mapping/20_missing_type/Existent and non-existent type returns 404 and the existing type}
CompatRestIT. test {yaml=indices.get_mapping/20_missing_type/Existent and non-existent types returns 404 and the existing type}
CompatRestIT. test {yaml=indices.get_mapping/20_missing_type/No type matching pattern returns 404}
CompatRestIT. test {yaml=indices.get_mapping/20_missing_type/Non-existent type returns 404}
CompatRestIT. test {yaml=indices.get_mapping/20_missing_type/Type missing when no types exist}
CompatRestIT. test {yaml=indices.get_mapping/61_empty_with_types/Check empty mapping when getting all mappings via /_mapping}
CompatRestIT. test {yaml=indices.get_template/11_basic_with_types/Get template with no mappings}
CompatRestIT. test {yaml=indices.get_template/11_basic_with_types/Get template}
CompatRestIT. test {yaml=indices.put_mapping/20_mix_typeless_typeful/PUT mapping with _doc on an index that has types}
CompatRestIT. test {yaml=indices.put_mapping/20_mix_typeless_typeful/PUT mapping with typeless API on an index that has types}
CompatRestIT. test {yaml=indices.put_template/10_basic/Put template with explicit _doc type}
CompatRestIT. test {yaml=indices.put_template/11_basic_with_types/Put multiple template}
CompatRestIT. test {yaml=indices.put_template/11_basic_with_types/Put template with empty mappings}
CompatRestIT. test {yaml=indices.put_template/11_basic_with_types/Put template}
CompatRestIT. test {yaml=indices.rollover/40_mapping/Mappings with explicit _doc type}
CompatRestIT. test {yaml=indices.rollover/41_mapping_with_types/Typeless mapping}
CompatRestIT. test {yaml=indices.rollover/50_data_streams/Roll over a data stream}
CompatRestIT. test {yaml=indices.shrink/30_copy_settings/Copy settings during shrink index}
CompatRestIT. test {yaml=indices.split/30_copy_settings/Copy settings during split index}
CompatRestIT. test {yaml=indices.stats/15_types/Types - _all metric}
CompatRestIT. test {yaml=indices.stats/15_types/Types - indexing metric}
CompatRestIT. test {yaml=indices.stats/15_types/Types - multi metric}
CompatRestIT. test {yaml=indices.stats/15_types/Types - multi}
CompatRestIT. test {yaml=indices.stats/15_types/Types - one}
CompatRestIT. test {yaml=indices.stats/15_types/Types - pattern}
CompatRestIT. test {yaml=indices.stats/15_types/Types - star}
CompatRestIT. test {yaml=indices.stats/20_translog/Translog retention settings are deprecated}
CompatRestIT. test {yaml=indices.stats/20_translog/Translog retention without soft_deletes}
CompatRestIT. test {yaml=indices.stats/20_translog/Translog stats on closed indices without soft-deletes}
CompatRestIT. test {yaml=mget/10_basic/Basic multi-get}
CompatRestIT. test {yaml=mget/11_default_index_type/Default index/type}
CompatRestIT. test {yaml=mget/14_alias_to_multiple_indices/Multi Get with alias that resolves to multiple indices}
CompatRestIT. test {yaml=mget/16_basic_with_types/Basic multi-get}
CompatRestIT. test {yaml=mget/17_default_index/Default index/type}
CompatRestIT. test {yaml=mget/18_non_existent_index_with_types/Non-existent index}
CompatRestIT. test {yaml=mget/19_missing_metadata_with_types/Missing metadata}
CompatRestIT. test {yaml=mget/21_alias_to_multiple_indices_with_types/Multi Get with alias that resolves to multiple indices}
CompatRestIT. test {yaml=mget/22_ids_with_types/IDs}
CompatRestIT. test {yaml=mget/23_stored_fields_with_types/Stored fields}
CompatRestIT. test {yaml=mget/41_routing_with_types/Routing}
CompatRestIT. test {yaml=mget/61_realtime_refresh_with_types/Realtime Refresh}
CompatRestIT. test {yaml=mget/71_source_filtering_with_types/Source filtering - exclude field}
CompatRestIT. test {yaml=mget/71_source_filtering_with_types/Source filtering - include field}
CompatRestIT. test {yaml=mget/71_source_filtering_with_types/Source filtering - include nested field}
CompatRestIT. test {yaml=mget/71_source_filtering_with_types/Source filtering - true/false}
CompatRestIT. test {yaml=mlt/20_docs/Basic mlt query with docs}
CompatRestIT. test {yaml=mlt/30_unlike/Basic mlt query with unlike}
CompatRestIT. test {yaml=search.aggregation/10_histogram/Deprecated _time order}
CompatRestIT. test {yaml=search.aggregation/200_top_hits_metric/top_hits aggregation with sequence numbers}
CompatRestIT. test {yaml=search.aggregation/20_terms/Deprecated _term order}
CompatRestIT. test {yaml=search.aggregation/51_filter_with_types/Filter aggs with terms lookup and ensure it's cached}
CompatRestIT. test {yaml=search.inner_hits/10_basic/Nested doc version and seqIDs}
CompatRestIT. test {yaml=search.inner_hits/10_basic/Nested inner hits}
CompatRestIT. test {yaml=search/100_stored_fields/Stored fields}
CompatRestIT. test {yaml=search/10_source_filtering/docvalue_fields with default format}
CompatRestIT. test {yaml=search/110_field_collapsing/field collapsing and from}
CompatRestIT. test {yaml=search/110_field_collapsing/field collapsing and inner_hits}
CompatRestIT. test {yaml=search/110_field_collapsing/field collapsing and multiple inner_hits}
CompatRestIT. test {yaml=search/110_field_collapsing/field collapsing, inner_hits and maxConcurrentGroupRequests}
CompatRestIT. test {yaml=search/110_field_collapsing/field collapsing, inner_hits and seq_no}
CompatRestIT. test {yaml=search/110_field_collapsing/field collapsing, inner_hits and version}
CompatRestIT. test {yaml=search/110_field_collapsing/field collapsing}
CompatRestIT. test {yaml=search/150_rewrite_on_coordinator/Ensure that we fetch the document only once}
CompatRestIT. test {yaml=search/171_terms_query_with_types/Terms Query with No.of terms exceeding index.max_terms_count should FAIL}
CompatRestIT. test {yaml=search/20_default_values/Basic search}
CompatRestIT. test {yaml=search/310_match_bool_prefix/multi_match multiple fields with cutoff_frequency throws exception}
CompatRestIT. test {yaml=search/40_indices_boost/Indices boost using object}
CompatRestIT. test {yaml=search/70_response_filtering/Search with response filtering}
CompatRestIT. test {yaml=search/90_search_after/search with search_after parameter}
CompatRestIT. test {yaml=search_shards/10_basic/Search shards aliases with and without filters}
CompatRestIT. test {yaml=snapshot.get/10_basic/Get missing snapshot info succeeds when ignore_unavailable is true}
CompatRestIT. test {yaml=snapshot.get/10_basic/Get missing snapshot info throws an exception}
CompatRestIT. test {yaml=snapshot.get/10_basic/Get snapshot info contains include_global_state}
CompatRestIT. test {yaml=snapshot.get/10_basic/Get snapshot info when verbose is false}
CompatRestIT. test {yaml=snapshot.get/10_basic/Get snapshot info with metadata}
CompatRestIT. test {yaml=snapshot.get/10_basic/Get snapshot info}
CompatRestIT. test {yaml=suggest/20_completion/Suggestions with source should work}
CompatRestIT. test {yaml=termvectors/20_issue7121/Term vector API should return 'found: false' for docs between index and refresh}
CompatRestIT. test {yaml=termvectors/21_issue7121_with_types/Term vector API should return 'found: false' for docs between index and refresh}
CompatRestIT. test {yaml=termvectors/50_mix_typeless_typeful/Term vectors with typeless API on an index that has types}
Generated by Gradle 6.5 at Jul 14, 2020, 4:31:56 PM
@pgomulka pgomulka marked this pull request as ready for review July 14, 2020 12:54
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 14, 2020

Pinging @elastic/es-core-infra (:Core/Infra/REST API)
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Jul 14, 2020
@pgomulka pgomulka merged commit b09bd5a into elastic:compat_rest_api Jul 14, 2020
@pgomulka pgomulka changed the title WIP mappings get put and get mappings Mappings get put and get mappings Jul 14, 2020
@pgomulka pgomulka removed the WIP label Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Core/Infra/REST API REST infrastructure and utilities Team:Core/Infra Meta label for core/infra team

2 participants

@pgomulka @elasticmachine