Remove the listener thread pool #53314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This commit completes the work to remove the listener thread pool, having removed all uses of it in the server codebase, and deprecated it in 7.x. With this commit, we also remove the infrastructgure to deprecate a fixed thread pool, which was added as part of this work, since it is easy to bring back if needed.
jasontedor added >breaking :Core/Infra/Core 
Collaborator
| Pinging @elastic/es-core-infra (:Core/Infra/Core) |
6 tasks
original-brownbear approved these changes Mar 9, 2020
| s -> Integer.toString(size), | ||
| s -> Setting.parseInt(s, 1, applyHardSizeLimit(settings, name), sizeKey), | ||
| properties); | ||
| new Setting<>( |
Contributor
There was a problem hiding this comment.
NIT: is the indent change intended here?
Member Author
There was a problem hiding this comment.
So, to deprecate the listener thread pool, I added some temporary infrastructure in this class (see #53266) which changed the indentation here because of my IDE having different settings than when I authored this code a long time ago. 🤷♀
Since after removing this setting this infrastructure isn't needed anymore, I simply reverted the file back to its initial state before #53266, including the original formatting.
Long live automatic code formatting!
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Jan 14, 2021
In elastic#53314 we removed the listener threadpool but left in place a now-mysterious comment about its configuration. This commit removes the orphaned comment.
DaveCTurner added a commit that referenced this pull request Jan 14, 2021
In #53314 we removed the listener threadpool but left in place a now-mysterious comment about its configuration. This commit removes the orphaned comment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This commit completes the work to remove the listener thread pool, having removed all uses of it in the server codebase, and deprecated it in 7.x. With this commit, we also remove the infrastructgure to deprecate a fixed thread pool, which was added as part of this work, since it is easy to bring back if needed.
Closes #53049