Remove type metadata from ingest documents #50131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
romseygeek added >breaking :Data Management/Ingest Node 
Collaborator
| Pinging @elastic/es-core-features (:Core/Features/Ingest) |
SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this pull request Jan 23, 2020
Referring to the _type field in an Ingest document has been deprecated and effectively a no-op since 7.x, and we can remove support for it entirely in 8.0 Relates to elastic#41059
66 tasks
probakowski added a commit that referenced this pull request Feb 19, 2021
After #66197 we've lost ability to use longs for version, if_seq_no and if_primary_term (only ints would work). That slipped through because 1 test went missing after refactoring in #50131. This change fixes that with new ConfigurationUtils.readOptionalStringOrLongProperty method and and brings back the test.
80 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Referring to the
_typefield in an Ingest document has been deprecated and effectivelya no-op since 7.x, and we can remove support for it entirely in 8.0
Relates to #41059