Remove deprecated include-type methods from HLRC indices client #48471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
romseygeek added :Data Management/Indices APIs 
Collaborator
| Pinging @elastic/es-core-features (:Core/Features/Java High Level REST Client) |
mayya-sharipova approved these changes Oct 24, 2019
Contributor
mayya-sharipova left a comment
mayya-sharipova left a comment There was a problem hiding this comment.
@romseygeek Thanks Alan, makes sense
jtibshirani approved these changes Oct 24, 2019
Contributor
jtibshirani left a comment
jtibshirani left a comment There was a problem hiding this comment.
Also looks good to me!
Contributor
| I don’t think this should have any impact on Kibana, FYI |
66 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
We have a number of deprecated methods on the high-level Rest client's
IndicesClientthat take server-side object classes and allow users to passthe
include_type_nameparameter. These all have equivalent methods thatuse HLRC classes instead, the only difference being the lack of the types
parameter.
This commit removes these deprecated methods.