Remove the ability to update datafeed's job_id. #44752
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
| Pinging @elastic/ml-core |
droberts195 reviewed Jul 25, 2019
x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ml/datafeed/DatafeedUpdate.java Outdated Show resolved Hide resolved
client/rest-high-level/src/main/java/org/elasticsearch/client/ml/datafeed/DatafeedUpdate.java Outdated Show resolved Hide resolved
przemekwitek force-pushed the remove_updating_job_id branch from 0894550 to 84008ed Compare 
przemekwitek force-pushed the remove_updating_job_id branch from 852cf2a to 9b92782 Compare 
Contributor Author
| run elasticsearch-ci/1 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR is a followup to #44691. It disables the possibility to update job_id on a datafeed.
DatafeedUpdate.jobId field can be set in the _update request as long as it is the same as the current value of DatafeedConfig.jobId.
Closes #44616