[ILM] refactor ExplainLifecycleRequest to enforce indices #35753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Previously, it was possible to initialize a request that does not include any indices. This results in undefined behavior when generating the URL path to send to ES. By enforcing indices to be defined, users will be more explicit about the intention.
talevy added >refactoring >non-issue :Data Management/ILM+SLM 
Collaborator
| Pinging @elastic/es-core-features |
gwbrown approved these changes Nov 20, 2018
...evel/src/test/java/org/elasticsearch/client/indexlifecycle/ExplainLifecycleRequestTests.java Outdated Show resolved Hide resolved
...igh-level/src/main/java/org/elasticsearch/client/indexlifecycle/ExplainLifecycleRequest.java Outdated Show resolved Hide resolved
…indexlifecycle/ExplainLifecycleRequestTests.java Co-Authored-By: talevy <JubBoy333@gmail.com>
…indexlifecycle/ExplainLifecycleRequest.java Co-Authored-By: talevy <JubBoy333@gmail.com>
Contributor Author
| thanks for the review @gwbrown -- definitely thought retry was the right word at the time :) |
talevy added a commit that referenced this pull request Nov 21, 2018
Previously, it was possible to initialize a request that does not include any indices. This results in undefined behavior when generating the URL path to send to ES. By enforcing indices to be defined, users will be more explicit about the intention.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Previously, it was possible to initialize a request
that does not include any indices. This results in undefined
behavior when generating the URL path to send to ES. By
enforcing indices to be defined, users will be more explicit
about the intention.