Fix line length for org.elasticsearch.action.* files #35607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This removes the checkstyle suppressions for things in the `action` package. Relates to elastic#34884
dakrone added >non-issue :Core/Infra/Core 
Collaborator
| Pinging @elastic/es-core-infra |
33 tasks
nik9000 reviewed Nov 16, 2018
...src/main/java/org/elasticsearch/action/termvectors/TransportShardMultiTermsVectorAction.java Outdated Show resolved Hide resolved
nik9000 reviewed Nov 16, 2018
| * Sets the index request to be used if the document does not exists. Otherwise, a {@link org.elasticsearch.index.engine.DocumentMissingException} | ||
| * is thrown. | ||
| * Sets the index request to be used if the document does not exists. Otherwise, a | ||
| * {@link org.elasticsearch.index.engine.DocumentMissingException} is thrown. |
Member
There was a problem hiding this comment.
I think you can import this class and this'll be easier to read.
server/src/test/java/org/elasticsearch/action/admin/cluster/settings/SettingsUpdaterTests.java Outdated Show resolved Hide resolved
dakrone added a commit to dakrone/elasticsearch that referenced this pull request Nov 16, 2018
This removes the checkstyle suppressions for things in the `action` package. Relates to elastic#34884 Backport of elastic#35607
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Nov 17, 2018
* master: (59 commits) SQL: Move internals from Joda to java.time (elastic#35649) Add HLRC docs for Get Lifecycle Policy (elastic#35612) Align RolloverStep's name with other step names (elastic#35655) Watcher: Use joda method to get local TZ (elastic#35608) Fix line length for org.elasticsearch.action.* files (elastic#35607) Remove use of AbstractComponent in server (elastic#35444) Deprecate types in count and msearch. (elastic#35421) Refactor an ambigious TermVectorsRequest constructor. (elastic#35614) [Scripting] Use Number as a return value for BucketAggregationScript (elastic#35653) Removes AbstractComponent from several classes (elastic#35566) [DOCS] Add beta warning to ILM pages. (elastic#35571) Deprecate types in validate query requests. (elastic#35575) Unmute BuildExamplePluginsIT Revert "AwaitsFix the RecoveryIT suite - see elastic#35597" Revert "[RCI] Check blocks while having index shard permit in TransportReplicationAction (elastic#35332)" Remove remaining line length violations for o.e.action.admin.cluster (elastic#35156) ML: Adjusing BWC version post backport to 6.6 (elastic#35605) [TEST] Replace fields in response with actual values Remove usages of CharSequence in Sets (elastic#35501) AwaitsFix the RecoveryIT suite - see elastic#35597 ...
dakrone added a commit that referenced this pull request Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This removes the checkstyle suppressions for things in the
actionpackage.Relates to #34884