[CCR] Get all auto follow patterns and no auto follow metadata #35381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Return empty response when querying all auto follow patterns, but there is no auto follow metadata.
martijnvg added >non-issue :Distributed Indexing/CCR 
Collaborator
| Pinging @elastic/es-distributed |
…_patterns_no_auto_follow_metadata
…_patterns_no_auto_follow_metadata
…_patterns_no_auto_follow_metadata
…_patterns_no_auto_follow_metadata
bleskes approved these changes Nov 9, 2018
Contributor
bleskes left a comment
bleskes left a comment There was a problem hiding this comment.
LGTM. Maybe add a rest test too?
Member Author
A rest test is the ultimate verification whether this works, but I don't think we should add a rest for all possible ways an API can be used. In this case just having a unit test that verifies whether an empty map is returned or an illegal argument is thrown is sufficient, because we now how an empty map gets serialized and how a |
martijnvg added a commit that referenced this pull request Nov 9, 2018
Return empty response when querying all auto follow patterns, but there is no auto follow metadata.
martijnvg added a commit that referenced this pull request Nov 9, 2018
Return empty response when querying all auto follow patterns, but there is no auto follow metadata.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Return empty response when querying all auto follow patterns,
but there is no auto follow metadata.