Skip to content

Conversation

@cbuescher
Copy link
Member

Adds a note to warn users about the limit introduced in #26541.

Adds a note to warn users about the limit introduced in elastic#26541.
@cbuescher cbuescher added >docs General docs changes >breaking :Search/Search Search-related issues that do not fall into other categories v7.0.0 labels Oct 26, 2018
@cbuescher cbuescher requested a review from jimczi October 26, 2018 16:33
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

@cbuescher cbuescher changed the title [Docs] Add nmigration note about expanded fields limit [Docs] Add migration note about expanded fields limit Oct 26, 2018
Copy link
Contributor

@jimczi jimczi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cbuescher . I left some comments

Executing queries that use automatic expansion of fields (e.g. `query_string`, `simple_query_string`
or `multi_match`) can have performance issues for indices with a large numbers of fields.
To safeguard against this, a fixed limit of a maximum of 1024 fields has been introduced
for queries using the "all fields" mode ("default_field": "*").
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is applied to any expansion so not only * but also a* or a,b,c,d*


Executing queries that use automatic expansion of fields (e.g. `query_string`, `simple_query_string`
or `multi_match`) can have performance issues for indices with a large numbers of fields.
To safeguard against this, a fixed limit of a maximum of 1024 fields has been introduced
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an hard limit of 1024 fields ?

@cbuescher
Copy link
Member Author

@jimczi I updated the text according to your comments. Would you be able to take another look?

Copy link
Contributor

@jimczi jimczi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating @cbuescher !

@cbuescher cbuescher merged commit 389910f into elastic:master Oct 29, 2018
kcm pushed a commit that referenced this pull request Oct 30, 2018
Adds a note to warn users about the limit introduced in #26541.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>breaking >docs General docs changes :Search/Search Search-related issues that do not fall into other categories v7.0.0-beta1

4 participants