Pass the host name on as server_name if proxy mode is on #34559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
s1monw added >enhancement :Distributed Coordination/Network 
Collaborator
| Pinging @elastic/es-distributed |
In remote cluster setup if we see a configured proxy we should set the seed nodes host name as the `server_name` to trigger SNI based routing even for seed nodes. Since remote cluster connections are plain TCP connections we have to set the host manually since the other side can't take it from the request URL like in the HTTP case. This also adds some more informative logging to remote cluster connection.
s1monw force-pushed the pass_server_name_for_proxy branch from 7ce7210 to a070c7a Compare s1monw added a commit that referenced this pull request Oct 17, 2018
In remote cluster setup if we see a configured proxy we should set the seed nodes host name as the `server_name` to trigger SNI based routing even for seed nodes. Since remote cluster connections are plain TCP connections we have to set the host manually since the other side can't take it from the request URL like in the HTTP case. This also adds some more informative logging to remote cluster connection.
kcm pushed a commit that referenced this pull request Oct 30, 2018
In remote cluster setup if we see a configured proxy we should set the seed nodes host name as the `server_name` to trigger SNI based routing even for seed nodes. Since remote cluster connections are plain TCP connections we have to set the host manually since the other side can't take it from the request URL like in the HTTP case. This also adds some more informative logging to remote cluster connection.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
In remote cluster setup if we see a configured proxy we should set
the seed nodes host name as the
server_nameto trigger SNI basedrouting even for seed nodes. Since remote cluster connections are
plain TCP connections we have to set the host manually since the other
side can't take it from the request URL like in the HTTP case.
This also adds some more informative logging to remote cluster connection.