Skip to content

Remove deprecated constant for default elser inference id #137329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 29, 2025
Merged

Remove deprecated constant for default elser inference id #137329

merged 7 commits into from
Oct 29, 2025

Conversation

@mridula-s109
Copy link
Contributor

@mridula-s109 mridula-s109 commented Oct 29, 2025 •
edited
Loading

Followup on this PR to remove the old constant being used in SemanticMapperTests pulled from main.
@mridula-s109 mridula-s109 requested a review from ioanatia October 29, 2025 11:08
@mridula-s109 mridula-s109 self-assigned this Oct 29, 2025
@mridula-s109 mridula-s109 marked this pull request as ready for review October 29, 2025 11:09
@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label v9.3.0 labels Oct 29, 2025
@mridula-s109 mridula-s109 added >bug :SearchOrg/Relevance Label for the Search (solution/org) Relevance team Team:Search - Relevance The Search organization Search Relevance team labels Oct 29, 2025
@elasticsearchmachine elasticsearchmachine removed the needs:triage Requires assignment of a team area label label Oct 29, 2025
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Oct 29, 2025

Hi @mridula-s109, I've created a changelog YAML for you.
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Oct 29, 2025

Pinging @elastic/search-relevance (Team:Search - Relevance)
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Oct 29, 2025

Hi @mridula-s109, I've updated the changelog YAML for you.
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Oct 29, 2025

Hi @mridula-s109, I've updated the changelog YAML for you.
@dimitris-athanasiou
Copy link
Contributor

dimitris-athanasiou commented Oct 29, 2025 •
edited
Loading

As this never got released, I would label it non-issue and not bug. Thus, no changelog entry is needed. I would probably also remove the fix from the PR title and call it something like Remove deprecated constant for default elser inference id.
dimitris-athanasiou
dimitris-athanasiou reviewed Oct 29, 2025
View reviewed changes
Copy link
Contributor

@dimitris-athanasiou dimitris-athanasiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we should remove the changelog and label it non-issue.
@mridula-s109 mridula-s109 changed the title Followup default EIS fix Remove deprecated constant for default elser inference id Oct 29, 2025
dimitris-athanasiou
dimitris-athanasiou approved these changes Oct 29, 2025
View reviewed changes
Copy link
Contributor

@dimitris-athanasiou dimitris-athanasiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@mridula-s109
Copy link
Contributor Author

mridula-s109 commented Oct 29, 2025

LGTM

Thankyou, As i have confirmed with @ioanatia as well, i am going ahead with the merge as its a simple cleanup.
kderusso
kderusso approved these changes Oct 29, 2025
View reviewed changes
Copy link
Member

@kderusso kderusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up!
@kderusso
Copy link
Member

kderusso commented Oct 29, 2025

@mridula-s109 Feel free to set auto merge on this one 😉
@mridula-s109 mridula-s109 enabled auto-merge (squash) October 29, 2025 13:13
@mridula-s109 mridula-s109 merged commit d07a003 into elastic:main Oct 29, 2025
34 checks passed
shmuelhanoch pushed a commit to shmuelhanoch/elasticsearch that referenced this pull request Oct 29, 2025
@mridula-s109 @shmuelhanoch
Remove deprecated constant for default elser inference id (elastic#13…
4fe26b6 
…7329) * Cleaned up the old constant * Cleaned up test * Update docs/changelog/137329.yaml * Update docs/changelog/137329.yaml * Update docs/changelog/137329.yaml * Delete docs/changelog/137329.yaml
chrisparrinello pushed a commit to chrisparrinello/elasticsearch that referenced this pull request Nov 3, 2025
@mridula-s109 @chrisparrinello
Remove deprecated constant for default elser inference id (elastic#13…
84ed97c 
…7329) * Cleaned up the old constant * Cleaned up test * Update docs/changelog/137329.yaml * Update docs/changelog/137329.yaml * Update docs/changelog/137329.yaml * Delete docs/changelog/137329.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>non-issue :SearchOrg/Relevance Label for the Search (solution/org) Relevance team Team:Search - Relevance The Search organization Search Relevance team v9.3.0

5 participants

@mridula-s109 @elasticsearchmachine @dimitris-athanasiou @kderusso @ioanatia