Remove explicit inference model information for Fleet .integration_knowledge #136837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…nowledge` Follow up to https://github.com/elastic/elasticsearch/pull/132506/files#r2285096764. With #133171 fixed, we should no longer have to set the explicit inference ID for this `semantic_text` field. Ideally this will also let us take advantage of EIS becoming the default inference endpoint (whenever that happens) for Cloud, while defaulting to `.elser-2-elasticsearch` for on-prem.
elasticsearchmachine added v9.3.0 needs:triage 
jen-huang added Team:Fleet Team:Search Relevance elasticsearchmachine removed needs:triage jen-huang added >non-issue needs:triage elasticsearchmachine removed the Team:Search Relevance 
Collaborator
| Pinging @elastic/search-inference-team (Team:Search - Inference) |
kderusso approved these changes Oct 20, 2025
Member
kderusso left a comment
kderusso left a comment There was a problem hiding this comment.
This looks fine to me, but I don't think it's a blocker because we're not yet defaulting to EIS. Also, model settings probably shouldn't have ever been set, and I would recommend removing them if they're set elsewhere.
Contributor Author
This is prepping for EIS becoming default because if we have it set like this, EIS won't be used when it does become the default. Correct, model settings shouldn't have ever been set, this index was introduced for 9.2 but there was a bug with leaving inference info empty for system indices which has been fixed now (#133171). Thank you for reviewing!! |
jen-huang added the auto-backport jen-huang added a commit that referenced this pull request Oct 20, 2025
…nowledge` (#136837) Follow up to https://github.com/elastic/elasticsearch/pull/132506/files#r2285096764. With #133171 fixed, we should no longer have to set the explicit inference ID for this `semantic_text` field. Ideally this will also let us take advantage of EIS becoming the default inference endpoint (whenever that happens) for Cloud, while defaulting to `.elser-2-elasticsearch` for on-prem.
Contributor Author
| I think I added the auto-backport label too late... alas. Manual backport here: #136844 |
jen-huang added a commit that referenced this pull request Oct 20, 2025
…nowledge` (#136837) (#136844) Follow up to https://github.com/elastic/elasticsearch/pull/132506/files#r2285096764. With #133171 fixed, we should no longer have to set the explicit inference ID for this `semantic_text` field. Ideally this will also let us take advantage of EIS becoming the default inference endpoint (whenever that happens) for Cloud, while defaulting to `.elser-2-elasticsearch` for on-prem.
chrisparrinello pushed a commit to chrisparrinello/elasticsearch that referenced this pull request Oct 24, 2025
…nowledge` (elastic#136837) Follow up to https://github.com/elastic/elasticsearch/pull/132506/files#r2285096764. With elastic#133171 fixed, we should no longer have to set the explicit inference ID for this `semantic_text` field. Ideally this will also let us take advantage of EIS becoming the default inference endpoint (whenever that happens) for Cloud, while defaulting to `.elser-2-elasticsearch` for on-prem.
fzowl pushed a commit to voyage-ai/elasticsearch that referenced this pull request Nov 3, 2025
…nowledge` (elastic#136837) Follow up to https://github.com/elastic/elasticsearch/pull/132506/files#r2285096764. With elastic#133171 fixed, we should no longer have to set the explicit inference ID for this `semantic_text` field. Ideally this will also let us take advantage of EIS becoming the default inference endpoint (whenever that happens) for Cloud, while defaulting to `.elser-2-elasticsearch` for on-prem.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Relates to elastic/kibana#239796
Follow up to https://github.com/elastic/elasticsearch/pull/132506/files#r2285096764.
With #133171 fixed, we should no longer have to set the explicit inference ID for this
semantic_textfield.Ideally this will also let us take advantage of EIS becoming the default inference endpoint for Cloud (whenever that happens), while defaulting to
.elser-2-elasticsearchfor on-prem.This is being treated as a blocker for 9.2.0 as part of elastic/kibana#239796. We don't want users to have this index installed with explicit IDs before EIS becomes the default.