Fix label filter for proper prefix/suffix regex #136588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
felixbarny added >non-issue :StorageEngine/ES|QL 
elasticsearchmachine added Team:StorageEngine external-contributor 
Collaborator
| Pinging @elastic/es-storage-engine (Team:StorageEngine) |
Member Author
| I've created an issue for adding first-class support for proper prefix/suffix queries to ES|QL: #136615 |
felixbarny force-pushed the promql-proper-prefix branch from 79d8e08 to 210c6d2 Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Previously, we were converting literal label filters starting or ending with one of
.*and.+to a prefix/suffix query. However,.+implies that there's at least more character. This is also known as a "proper prefix" or "proper suffix". In other words, it's a prefix or suffix but not the term itself.Seems like we don't have a builtin functionality for proper prefix/suffix matching, so this translates it to
new And(source, new NotEquals(source, field, value), new StartsWith(source, field, value)).I can work separately on adding a parameter to
STARTS_WITH/ENDS_WITHor creating dedicated functions likePROPER_PREFIX/SUFFIXor something like that (as a PR on targeting main). Once that is in, I'll go back and change this. I don't think this PR would be blocked on that, though.