- Notifications
You must be signed in to change notification settings - Fork 25.6k
[ML] Future proof index names in REST tests #136458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
edsavage merged 4 commits into elastic:main from edsavage:future_proof_ml_yaml_rest_compat_tests Oct 19, 2025
Merged
[ML] Future proof index names in REST tests #136458
edsavage merged 4 commits into elastic:main from edsavage:future_proof_ml_yaml_rest_compat_tests Oct 19, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Some ML REST tests make explicit reference to the AD results index, making the assumption that the index name will be `.ml-anomalies-shared`. This may not always be the case going forward in which cae REST compatibility tests will break. The bulk of the references can be handled by the yamlRestCompatTest transformation rules but a small number must be manually rewritten.
Collaborator
| Pinging @elastic/ml-core (Team:ML) |
…ture_proof_ml_yaml_rest_compat_tests
davidkyle approved these changes Oct 16, 2025
Member
davidkyle left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This was referenced Oct 19, 2025
Collaborator
edsavage added a commit to edsavage/elasticsearch that referenced this pull request Oct 19, 2025
Some ML REST tests make explicit reference to the AD results index, making the assumption that the index name will be `.ml-anomalies-shared`. This may not always be the case going forward in which cae REST compatibility tests will break. The bulk of the references can be handled by the yamlRestCompatTest transformation rules but a small number must be manually rewritten.
edsavage added a commit to edsavage/elasticsearch that referenced this pull request Oct 19, 2025
Some ML REST tests make explicit reference to the AD results index, making the assumption that the index name will be `.ml-anomalies-shared`. This may not always be the case going forward in which cae REST compatibility tests will break. The bulk of the references can be handled by the yamlRestCompatTest transformation rules but a small number must be manually rewritten.
edsavage added a commit to edsavage/elasticsearch that referenced this pull request Oct 19, 2025
Some ML REST tests make explicit reference to the AD results index, making the assumption that the index name will be `.ml-anomalies-shared`. This may not always be the case going forward in which cae REST compatibility tests will break. The bulk of the references can be handled by the yamlRestCompatTest transformation rules but a small number must be manually rewritten.
elasticsearchmachine pushed a commit that referenced this pull request Oct 19, 2025
Some ML REST tests make explicit reference to the AD results index, making the assumption that the index name will be `.ml-anomalies-shared`. This may not always be the case going forward in which cae REST compatibility tests will break. The bulk of the references can be handled by the yamlRestCompatTest transformation rules but a small number must be manually rewritten.
elasticsearchmachine pushed a commit that referenced this pull request Oct 19, 2025
Some ML REST tests make explicit reference to the AD results index, making the assumption that the index name will be `.ml-anomalies-shared`. This may not always be the case going forward in which cae REST compatibility tests will break. The bulk of the references can be handled by the yamlRestCompatTest transformation rules but a small number must be manually rewritten.
elasticsearchmachine pushed a commit that referenced this pull request Oct 19, 2025
Some ML REST tests make explicit reference to the AD results index, making the assumption that the index name will be `.ml-anomalies-shared`. This may not always be the case going forward in which cae REST compatibility tests will break. The bulk of the references can be handled by the yamlRestCompatTest transformation rules but a small number must be manually rewritten.
Contributor Author
| Removing backport label for |
chrisparrinello pushed a commit to chrisparrinello/elasticsearch that referenced this pull request Oct 24, 2025
Some ML REST tests make explicit reference to the AD results index, making the assumption that the index name will be `.ml-anomalies-shared`. This may not always be the case going forward in which cae REST compatibility tests will break. The bulk of the references can be handled by the yamlRestCompatTest transformation rules but a small number must be manually rewritten.
fzowl pushed a commit to voyage-ai/elasticsearch that referenced this pull request Nov 3, 2025
Some ML REST tests make explicit reference to the AD results index, making the assumption that the index name will be `.ml-anomalies-shared`. This may not always be the case going forward in which cae REST compatibility tests will break. The bulk of the references can be handled by the yamlRestCompatTest transformation rules but a small number must be manually rewritten.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged :ml Machine learning >non-issue Team:ML Meta label for the ML team >test Issues or PRs that are addressing/adding tests v8.19.6 v9.1.6 v9.2.1 v9.3.0
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Some ML REST tests make explicit reference to the AD results index, making the assumption that the index name will be
.ml-anomalies-shared. This may not always be the case going forward in which case REST compatibility tests will break.The bulk of the references can be handled by the
yamlRestCompatTesttransformation rules but a small number must be manually rewritten.Relates #136065