Fixing some test issues #129295
Merged
Fixing some test issues #129295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
| Pinging @elastic/es-security (Team:Security) |
Collaborator
| Hi @ankit--sethi, I've created a changelog YAML for you. |
ankit--sethi changed the title 
ankit--sethi commented Jun 12, 2025
...ject/src/javaRestTest/java/org/elasticsearch/xpack/security/SecurityRolesMultiProjectIT.java Show resolved Hide resolved
ankit--sethi commented Jun 12, 2025
x-pack/test/smb-fixture/src/main/java/org/elasticsearch/test/fixtures/smb/SmbTestContainer.java Outdated Show resolved Hide resolved
parkertimmins approved these changes Jun 12, 2025
x-pack/test/smb-fixture/src/main/java/org/elasticsearch/test/fixtures/smb/SmbTestContainer.java Outdated Show resolved Hide resolved
slobodanadamovic requested changes Jun 12, 2025
ankit--sethi added >test ...ject/src/javaRestTest/java/org/elasticsearch/xpack/security/SecurityRolesMultiProjectIT.java Show resolved Hide resolved
Contributor
| The #124490 was failing on 8.19. We should backport the fixes to older branches as well. The only tricky part here is that you'll have to selectively backport this PR given that |
Contributor Author
I'll backport them manually |
ankit--sethi added a commit to ankit--sethi/elasticsearch that referenced this pull request Jun 16, 2025
(cherry picked from commit e437163)
This was referenced Jun 16, 2025
ankit--sethi added a commit that referenced this pull request Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Attemping to resolve #124490 and #127738 and #126223