Skip to content

Conversation

@ldematte
Copy link
Contributor

@ldematte ldematte commented Mar 3, 2025

Fix assertions on messages to work with windows paths too.

Fixes #123657

@ldematte ldematte added >test Issues or PRs that are addressing/adding tests auto-backport Automatically create backport pull requests when merged v8.18.1 v8.19.0 v9.0.1 :Core/Infra/Entitlements Entitlements infrastructure labels Mar 3, 2025
@ldematte ldematte marked this pull request as ready for review March 3, 2025 10:16
@ldematte ldematte requested a review from a team as a code owner March 3, 2025 10:16
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label Mar 3, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@ldematte
Copy link
Contributor Author

ldematte commented Mar 3, 2025

@mosche thanks for adding the test-windows label. I re-triggered CI so it gets that.

Copy link
Contributor

@mosche mosche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ldematte ldematte enabled auto-merge (squash) March 3, 2025 10:44
@ldematte ldematte removed the test-windows Trigger CI checks on Windows label Mar 3, 2025
@ldematte
Copy link
Contributor Author

ldematte commented Mar 3, 2025

The failure in windows is due to #123850 not being backported successfully due to the test from this fix failing. It's a circular thing, I'm going to break it removing test-windows here and repeating CI so it merges cleanly

@ldematte ldematte merged commit 31b3f7d into elastic:main Mar 3, 2025
17 checks passed
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
8.18 Commit could not be cherrypicked due to conflicts
8.x Commit could not be cherrypicked due to conflicts
9.0 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 123856

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged :Core/Infra/Entitlements Entitlements infrastructure Team:Core/Infra Meta label for core/infra team >test Issues or PRs that are addressing/adding tests v8.18.1 v8.19.0 v9.0.1 v9.1.0

3 participants