Remove index blocks by default in create_from (#120643)

Change the default value for the `remove_index_blocks` parameter of the `_create_from` api to true. This means that when a source index has blocks, by default these blocks will be filtered out when creating the destination index.

Author: parkertimmins

docs/changelog/120643.yaml

@@ -0,0 +1,5 @@
+pr: 120643
+summary: Remove index blocks by default in `create_from`
+area: Indices APIs
+type: enhancement
+issues: []

x-pack/plugin/migrate/src/internalClusterTest/java/org/elasticsearch/xpack/migrate/action/CreateIndexFromSourceActionIT.java

@@ -222,7 +222,7 @@ public void testSettingsNullOverride() throws Exception {
  assertNull(destSettings.get(IndexMetadata.SETTING_BLOCKS_WRITE));
  }
 
- public void testRemoveIndexBlocks() throws Exception {
+ public void testRemoveIndexBlocksByDefault() throws Exception {
  assumeTrue("requires the migration reindex feature flag", REINDEX_DATA_STREAM_FEATURE_FLAG.isEnabled());
 
  var sourceIndex = randomAlphaOfLength(20).toLowerCase(Locale.ROOT);
@@ -241,12 +241,10 @@ public void testRemoveIndexBlocks() throws Exception {
 
  // create from source
  var destIndex = randomAlphaOfLength(20).toLowerCase(Locale.ROOT);
- assertAcked(
- client().execute(
- CreateIndexFromSourceAction.INSTANCE,
- new CreateIndexFromSourceAction.Request(sourceIndex, destIndex, settingsOverride, Map.of(), true)
- )
- );
+
+ CreateIndexFromSourceAction.Request request = new CreateIndexFromSourceAction.Request(sourceIndex, destIndex);
+ request.settingsOverride(settingsOverride);
+ assertAcked(client().execute(CreateIndexFromSourceAction.INSTANCE, request));
 
  // assert settings overridden
  var settingsResponse = indicesAdmin().getSettings(new GetSettingsRequest().indices(destIndex)).actionGet();

x-pack/plugin/migrate/src/main/java/org/elasticsearch/xpack/migrate/action/CreateIndexFromSourceAction.java

@@ -65,7 +65,7 @@ public static class Request extends ActionRequest implements IndicesRequest, ToX
  }
 
  public Request(String sourceIndex, String destIndex) {
- this(sourceIndex, destIndex, Settings.EMPTY, Map.of(), false);
+ this(sourceIndex, destIndex, Settings.EMPTY, Map.of(), true);
  }
 
  public Request(

x-pack/plugin/src/yamlRestTest/resources/rest-api-spec/test/migrate/30_create_from.yml

@@ -120,7 +120,40 @@ teardown:
  - match: {dest-index-1.mappings.properties.baz.type: integer}
 
 ---
-"Test create_from with remove_index_blocks":
+"Test create_from with remove_index_blocks set to false":
+ - requires:
+ reason: "migration reindex is behind a feature flag"
+ test_runner_features: [capabilities]
+ capabilities:
+ - method: POST
+ path: /_migration/reindex
+ capabilities: [migration_reindex]
+ - do:
+ indices.create:
+ index: source-index-1
+ body:
+ settings:
+ index:
+ blocks.write: true
+ blocks.read: true
+ - do:
+ migrate.create_from:
+ source: "source-index-1"
+ dest: "dest-index-1"
+ body:
+ settings_override:
+ index:
+ blocks.write: false
+ blocks.read: true
+ remove_index_blocks: false
+ - do:
+ indices.get_settings:
+ index: dest-index-1
+ - match: { dest-index-1.settings.index.blocks.write: "false" }
+ - match: { dest-index-1.settings.index.blocks.read: "true" }
+
+---
+"Test create_from with remove_index_blocks default of true":
  - requires:
  reason: "migration reindex is behind a feature flag"
  test_runner_features: [capabilities]
@@ -136,8 +169,6 @@ teardown:
  index:
  blocks.write: true
  blocks.read: true
- number_of_shards: 1
- number_of_replicas: 0
  - do:
  indices.create_from:
  source: "source-index-1"
@@ -147,11 +178,9 @@ teardown:
  index:
  blocks.write: false
  blocks.read: true
- remove_index_blocks: true
  - do:
  indices.get_settings:
  index: dest-index-1
- - match: { dest-index-1.settings.index.number_of_shards: "1" }
  - match: { dest-index-1.settings.index.blocks.write: null }
  - match: { dest-index-1.settings.index.blocks.read: null }