Skip to content

Commit c17cf18

Browse files
Add ensureGreen method for use with adminClient (#113425)
Current ensureGreen test helper method uses client() directly. Sometimes is useful to call ensureGreen with adminClient() or another rest client. This PR allows passing a RestClient into ensureGreen.
1 parent d07d167 commit c17cf18

File tree

3 files changed

+13
-9
lines changed

3 files changed

+13
-9
lines changed

docs/changelog/113425.yaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
pr: 113425
2+
summary: Add `ensureGreen` test method for use with `adminClient`
3+
area: Infra/Metrics
4+
type: enhancement
5+
issues: []

test/framework/src/main/java/org/elasticsearch/test/rest/ESRestTestCase.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1721,7 +1721,11 @@ protected String getEnsureGreenTimeout() {
17211721
* @param index index to test for
17221722
**/
17231723
public final void ensureGreen(String index) throws IOException {
1724-
ensureHealth(index, (request) -> {
1724+
ensureGreen(client(), index);
1725+
}
1726+
1727+
public final void ensureGreen(RestClient client, String index) throws IOException {
1728+
ensureHealth(client, index, (request) -> {
17251729
request.addParameter("wait_for_status", "green");
17261730
request.addParameter("wait_for_no_relocating_shards", "true");
17271731
final String ensureGreenTimeout = getEnsureGreenTimeout();

x-pack/qa/rolling-upgrade-multi-cluster/src/test/java/org/elasticsearch/upgrades/CcrRollingUpgradeIT.java

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -405,13 +405,8 @@ private static void resumeIndexFollowing(RestClient client, String followerIndex
405405
assertOK(client.performRequest(new Request("POST", "/" + followerIndex + "/_ccr/resume_follow")));
406406
}
407407

408-
private static void ensureGreen(RestClient client, String index) throws IOException {
409-
Request request = new Request("GET", "/_cluster/health/" + index);
410-
request.addParameter("wait_for_status", "green");
411-
request.addParameter("wait_for_no_relocating_shards", "true");
412-
request.addParameter("timeout", "70s");
413-
request.addParameter("level", "shards");
414-
client.performRequest(request);
408+
@Override
409+
protected final String getEnsureGreenTimeout() {
410+
return "70s";
415411
}
416-
417412
}

0 commit comments

Comments
 (0)