Remove unnecessary check for states.isEmpty() in predicates, enforce states is not empty in validate()

Author: JeremyDahlgren

server/src/main/java/org/elasticsearch/action/admin/cluster/snapshots/get/GetSnapshotsRequest.java

@@ -195,6 +195,9 @@ public ActionRequestValidationException validate() {
  } else if (after != null && fromSortValue != null) {
  validationException = addValidationError("can't use after and from_sort_value simultaneously", validationException);
  }
+ if (states.isEmpty()) {
+ validationException = addValidationError("states is empty", validationException);
+ }
  return validationException;
  }
 

server/src/main/java/org/elasticsearch/action/admin/cluster/snapshots/get/TransportGetSnapshotsAction.java

@@ -580,10 +580,7 @@ private boolean matchesPredicates(SnapshotId snapshotId, RepositoryData reposito
 
  final var details = repositoryData.getSnapshotDetails(snapshotId);
 
- if (states.isEmpty() == false
- && details != null
- && details.getSnapshotState() != null
- && states.contains(details.getSnapshotState()) == false) {
+ if (details != null && details.getSnapshotState() != null && states.contains(details.getSnapshotState()) == false) {
  return false;
  }
 
@@ -599,7 +596,7 @@ private boolean matchesPredicates(SnapshotInfo snapshotInfo) {
  return false;
  }
 
- if (states.isEmpty() == false && snapshotInfo.state() != null && states.contains(snapshotInfo.state()) == false) {
+ if (snapshotInfo.state() != null && states.contains(snapshotInfo.state()) == false) {
  return false;
  }