Skip to content

Commit dfd9e8d

Browse files
dmvassfxdgear
authored andcommitted
Deprecate the update_all_types option (#819)
This option makes no sense on indices that have only one type, which is enforced since 6.0.
1 parent d3204f6 commit dfd9e8d

File tree

2 files changed

+3
-7
lines changed

2 files changed

+3
-7
lines changed

Changelog.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ Changelog
55

66
6.4.0 (dev)
77
-----------
8+
* Removed deprecated option ``update_all_types``.
89

910
6.3.0 (2018-06-20)
1011
-----------

elasticsearch/client/indices.py

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -69,8 +69,7 @@ def flush(self, index=None, params=None):
6969
return self.transport.perform_request('POST', _make_path(index,
7070
'_flush'), params=params)
7171

72-
@query_params('master_timeout', 'timeout', 'update_all_types',
73-
'wait_for_active_shards')
72+
@query_params('master_timeout', 'timeout', 'wait_for_active_shards')
7473
def create(self, index, body=None, params=None):
7574
"""
7675
Create an index in Elasticsearch.
@@ -80,8 +79,6 @@ def create(self, index, body=None, params=None):
8079
:arg body: The configuration for the index (`settings` and `mappings`)
8180
:arg master_timeout: Specify timeout for connection to master
8281
:arg timeout: Explicit operation timeout
83-
:arg update_all_types: Whether to update the mapping for all fields with
84-
the same name across all types or not
8582
:arg wait_for_active_shards: Set the number of active shards to wait for
8683
before the operation returns.
8784
"""
@@ -240,7 +237,7 @@ def exists_type(self, index, doc_type, params=None):
240237
'_mapping', doc_type), params=params)
241238

242239
@query_params('allow_no_indices', 'expand_wildcards', 'ignore_unavailable',
243-
'master_timeout', 'timeout', 'update_all_types')
240+
'master_timeout', 'timeout')
244241
def put_mapping(self, doc_type, body, index=None, params=None):
245242
"""
246243
Register specific mapping definition for a specific type.
@@ -261,8 +258,6 @@ def put_mapping(self, doc_type, body, index=None, params=None):
261258
ignored when unavailable (missing or closed)
262259
:arg master_timeout: Specify timeout for connection to master
263260
:arg timeout: Explicit operation timeout
264-
:arg update_all_types: Whether to update the mapping for all fields with
265-
the same name across all types or not
266261
"""
267262
for param in (doc_type, body):
268263
if param in SKIP_IN_PATH:

0 commit comments

Comments
 (0)