Use service variants in system tests #424
Conversation
mtojek changed the title 
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
mtojek changed the title 
There was a problem hiding this comment.
Nice! LGTM, but could we run the CI job with all the integrations, or at least with mysql? In elastic/integrations#1145 I added the variants defined in Beats but I didn't test them 😬
| v2443: | ||
| SERVICE_VERSION: 2.4.43 | ||
| v2423: | ||
| SERVICE_VERSION: 2.4.23 |
There was a problem hiding this comment.
Have we considered to add something to skip variants? This may be needed in the future.
There was a problem hiding this comment.
We have the "skip" option for the entire test config not for particular variant. Maybe a follow up issue?
| } | ||
| | ||
| for _, cfgFile := range cfgFiles { | ||
| for _, variantName := range anyVariants(variantsFile) { |
There was a problem hiding this comment.
There should be some way to run with a single variant.
There was a problem hiding this comment.
I added CLI option for this:
elastic-package test system --variant foo
I can copy the mysql package to the test packages here, so we can test it. I will create a separate PR. |
Oh, forget it, I mixed things when I saw the apache tests passing 🙂 |
| /test |
3 participants
Fixes: #94
This PR introduces support for service variants for system tests. So far they are supported only in the
servicecommand.