Skip to content

Conversation

@jsoriano
Copy link
Member

If pipelines drop events during pipeline tests, they are set to nil, don't try to process them in any way to avoid failures.

elastic-package test pipeline reports this error:

ERROR: verifying test result failed: comparing test results failed: can't adjust test results: can't unmarshal event: unexpected end of JSON input 

Needed for elastic/integrations#1145

@jsoriano jsoriano requested a review from mtojek June 29, 2021 17:09
@jsoriano jsoriano self-assigned this Jun 29, 2021
@jsoriano jsoriano added the Team:Integrations Label for the Integrations team label Jun 29, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 29, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #397 updated

  • Start Time: 2021-06-30T07:50:14.717+0000

  • Duration: 21 min 45 sec

  • Commit: cd7e387

Test stats 🧪

Test Results
Failed 0
Passed 315
Skipped 2
Total 317

Trends 🧪

Image of Build Times

Image of Tests

Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an unfortunate use case where we need the "nil" value. Thank you for the fix.

@jsoriano
Copy link
Member Author

This is an unfortunate use case where we need the "nil" value. Thank you for the fix.

Well, this allows to validate that certain events are dropped, but it is true that something more explicit would be better.

@jsoriano jsoriano merged commit 7dc5ebd into elastic:master Jun 30, 2021
@jsoriano jsoriano deleted the nil-dropped-events branch June 30, 2021 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team:Integrations Label for the Integrations team

3 participants