Skip to content

[Bug] Integrations-Pr Command (Elastic-Package Linting and Version Adjustments) #2054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 24, 2022
Merged

[Bug] Integrations-Pr Command (Elastic-Package Linting and Version Adjustments) #2054

Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
332b61f
started solution for integrations-pr bug
terrancedejesus Jun 22, 2022
46fb46e
Merge branch 'main' into bug-integrations-pr-command
terrancedejesus Aug 16, 2022
671b9d8
Update devtools.py
terrancedejesus Aug 16, 2022
863e489
Update detection_rules/devtools.py
terrancedejesus Aug 16, 2022
b0ca45b
Merge branch 'main' into bug-integrations-pr-command
terrancedejesus Aug 22, 2022
ba3d31c
Merge branch 'main' into bug-integrations-pr-command
terrancedejesus Aug 23, 2022
bb5b1ce
Update detection_rules/devtools.py
terrancedejesus Aug 23, 2022
fec576c
Merge branch 'main' into bug-integrations-pr-command
Mikaayenson Aug 24, 2022
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions detection_rules/devtools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,7 +471,7 @@ def integrations_pr(ctx: click.Context, local_repo: str, token: str, draft: bool

local_repo = os.path.abspath(local_repo)
stack_version = Package.load_configs()["name"]
package_version = Package.load_configs()["registry_data"]["version"]
package_version = Package.load_configs()["registry_data"]["version"].split("-")[0]

release_dir = Path(RELEASE_DIR) / stack_version / "fleet" / package_version
message = f"[Security Rules] Update security rules package to v{package_version}"
Expand Down Expand Up @@ -541,7 +541,6 @@ def elastic_pkg(*args):
os.chdir(prev)

elastic_pkg("format")
elastic_pkg("lint")

# Upload the files to a branch
git("add", pkg_directory)
Expand Down Expand Up @@ -591,7 +590,7 @@ def elastic_pkg(*args):
click.echo("PR created:")
click.echo(pr.html_url)

# replace the changelog entry with the actual PR link
# # replace the changelog entry with the actual PR link
changelog_entries[0]["changes"][0]["link"] = pr.html_url
save_changelog()

Expand Down