Skip to content

Commit 8509e95

Browse files
authored
Merge branch 'master' into catch-exceptions-in-processors
2 parents 895931b + 5e2ebd3 commit 8509e95

File tree

9 files changed

+10
-13
lines changed

9 files changed

+10
-13
lines changed

.ci/.jenkins_exclude.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -226,8 +226,6 @@ exclude:
226226
FRAMEWORK: aioredis-newest
227227
- PYTHON_VERSION: python-3.10-rc # getting "loop argument must agree with lock" error
228228
FRAMEWORK: aioredis-newest
229-
- PYTHON_VERSION: python-3.10-rc
230-
FRAMEWORK: httpx-0.12
231229
# aiomysql
232230
- PYTHON_VERSION: pypy-3
233231
FRAMEWORK: aiomysql-newest

.ci/.jenkins_framework_full.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,8 @@ FRAMEWORK:
4141
- pymongo-3.4
4242
- pymongo-3.5
4343
- pymongo-newest
44-
- redis-2.8
45-
- redis-2.9
44+
- redis-3
45+
- redis-2
4646
- redis-newest
4747
- psycopg2-2.7
4848
- psycopg2-newest
@@ -74,7 +74,6 @@ FRAMEWORK:
7474
- pymemcache-3.0
7575
- pymemcache-newest
7676
- graphene-2
77-
- httpx-0.12
7877
- httpx-0.13
7978
- httpx-0.14
8079
- httpx-newest

elasticapm/instrumentation/packages/asyncio/httpcore.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ class HTTPCoreAsyncInstrumentation(AsyncAbstractInstrumentedModule):
4949

5050
instrument_list = [
5151
("httpcore._async.connection", "AsyncHTTPConnection.request"), # < httpcore 0.11
52-
("httpcore._async.connection", "AsyncHTTPConnection.arequest"), # httcore 0.11 - 0.12
52+
("httpcore._async.connection", "AsyncHTTPConnection.arequest"), # httpcore 0.11 - 0.12
5353
("httpcore._async.connection", "AsyncHTTPConnection.handle_async_request"), # >= httpcore 0.13
5454
]
5555

tests/instrumentation/asyncio_tests/aioredis_tests.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -125,14 +125,15 @@ async def test_redis_client(instrument, elasticapm_client, redis_conn):
125125
assert len(spans) == 3
126126

127127

128+
@pytest.mark.skip(reason="Test is flaky for some reason, possibly related to import-time instrumentation")
128129
@pytest.mark.integrationtest
129-
async def test_publish_subscribe(instrument, elasticapm_client, redis_conn):
130+
async def test_publish_subscribe_async(instrument, elasticapm_client, redis_conn):
130131
elasticapm_client.begin_transaction("transaction.test")
131132
with capture_span("test_publish_subscribe", "test"):
132133
# publish
133134
await redis_conn.publish("mykey", "a")
134135

135-
#subscribe
136+
# subscribe
136137
await redis_conn.subscribe("mykey")
137138

138139
elasticapm_client.end_transaction("MyView")

tests/instrumentation/redis_tests.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -165,6 +165,7 @@ def test_unix_domain_socket_connection_destination_info():
165165
assert destination_info["address"] == "unix:///some/path"
166166

167167

168+
@pytest.mark.skipif(redis.VERSION < (3,), reason="pubsub not available as context manager in redis-py 2")
168169
@pytest.mark.integrationtest
169170
def test_publish_subscribe(instrument, elasticapm_client, redis_conn):
170171
elasticapm_client.begin_transaction("transaction.test")
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
redis>=2.8,<2.9
1+
redis<3
22
-r reqs-base.txt

tests/requirements/reqs-redis-3.0.txt

Lines changed: 0 additions & 2 deletions
This file was deleted.
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
redis>=2.9,<2.10
1+
redis<4
22
-r reqs-base.txt
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
redis>=2.10
1+
redis
22
-r reqs-base.txt

0 commit comments

Comments
 (0)