Skip to content

Add handling for different exception types #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 18, 2018
Merged

Add handling for different exception types #128

merged 2 commits into from
Oct 18, 2018

Conversation

@bendavis78
Copy link
Contributor

@bendavis78 bendavis78 commented Oct 15, 2018

Most of the exceptions in exceptions.py don't seem to be used. This updates the client to raise the appropriate exception. I've also added ObjectNotFoundException as handling this during a .get() call is a very common use case.
@coveralls
Copy link

coveralls commented Oct 15, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 90.252% when pulling a961133 on bendavis78:exceptions into b254493 on sidecars:master.
@bendavis78 bendavis78 changed the title Added handling for different exception types Add handling for different exception types Oct 15, 2018
@ej2 ej2 merged commit de6a247 into ej2:master Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@bendavis78 @coveralls @ej2