Skip to content

Commit c769b19

Browse files
committed
ensure minorversion is checked properly
1 parent a77be22 commit c769b19

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

tests/unit/test_client.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ def test_update_object_with_request_id(self, make_req):
128128
qb_client.update_object("Customer", "request_body", request_id="123")
129129

130130
url = "https://sandbox-quickbooks.api.intuit.com/v3/company/1234/customer"
131-
make_req.assert_called_with("POST", url, "request_body", file_path=None, params=None, request_id="123")
131+
make_req.assert_called_with("POST", url, "request_body", file_path=None, file_bytes=None, request_id="123", params={'minorversion': client.QuickBooks.MINIMUM_MINOR_VERSION})
132132

133133
@patch('quickbooks.client.QuickBooks.get')
134134
def test_get_current_user(self, get):
@@ -155,7 +155,7 @@ def test_get_single_object(self, make_req):
155155

156156
qb_client.get_single_object("test", 1)
157157
url = "https://sandbox-quickbooks.api.intuit.com/v3/company/1234/test/1/"
158-
make_req.assert_called_with("GET", url, {}, params=None)
158+
make_req.assert_called_with("GET", url, {}, params={'minorversion': client.QuickBooks.MINIMUM_MINOR_VERSION})
159159

160160
@patch('quickbooks.client.QuickBooks.make_request')
161161
def test_get_single_object_with_params(self, make_req):
@@ -164,7 +164,7 @@ def test_get_single_object_with_params(self, make_req):
164164

165165
qb_client.get_single_object("test", 1, params={'param':'value'})
166166
url = "https://sandbox-quickbooks.api.intuit.com/v3/company/1234/test/1/"
167-
make_req.assert_called_with("GET", url, {}, params={'param':'value'})
167+
make_req.assert_called_with("GET", url, {}, params={'param':'value', 'minorversion': client.QuickBooks.MINIMUM_MINOR_VERSION})
168168

169169
@patch('quickbooks.client.QuickBooks.process_request')
170170
def test_make_request(self, process_request):
@@ -177,7 +177,8 @@ def test_make_request(self, process_request):
177177

178178
process_request.assert_called_with(
179179
"GET", url, data={},
180-
headers={'Content-Type': 'application/json', 'Accept': 'application/json', 'User-Agent': 'python-quickbooks V3 library'}, params={})
180+
headers={'Content-Type': 'application/json', 'Accept': 'application/json', 'User-Agent': 'python-quickbooks V3 library'},
181+
params={'minorversion': client.QuickBooks.MINIMUM_MINOR_VERSION})
181182

182183
def test_handle_exceptions(self):
183184
qb_client = client.QuickBooks()

0 commit comments

Comments
 (0)