Merge pull request major#306 from ofigueroa/bugfix_unitialized_value

Resolved issue major#304

Author: jmrenouard

mysqltuner.pl

@@ -5041,28 +5041,28 @@ sub mariadb_galera {
 having sum(if(c.column_key in ('PRI','UNI'), 1,0)) = 0"
  );
 
- if (get_wsrep_option('wsrep_slave_threads') > `nproc`*4 or get_wsrep_option('wsrep_slave_threads') < `nproc`*3) {
- badprint "wsrep_slave_threads is not equal to 3 or 4 times number of CPU(s)";
- push @adjvars, "wsrep_slave_threads= Nb of Core CPU * 4";
+ if ($myvar{'wsrep_slave_threads'} > `nproc` * 4 or $myvar{'wsrep_slave_threads'} < `nproc` * 2) {
+ badprint "wsrep_slave_threads is not equal to 2 or 4 times number of CPU(s)";
+ push @adjvars, "wsrep_slave_threads= Nb of Core CPU * 2";
  } else {
- goodprint "wsrep_slave_threads is equal to 3 or 4 times number of CPU(s)";
+ goodprint "wsrep_slave_threads is equal to 2 or 4 times number of CPU(s)";
  }
 
- if (get_wsrep_option('gcs.limit') != get_wsrep_option('wsrep_slave_threads') *5 ) {
- badprint "gcs.limit should be equal to 5 * wsrep_slave_threads";
- push @adjvars, "gcs.limit= wsrep_slave_threads * 5";
+ if (get_wsrep_option('gcs.fc_limit') != $myvar{'wsrep_slave_threads'} * 5 ) {
+ badprint "gcs.fc_limit should be equal to 5 * wsrep_slave_threads";
+ push @adjvars, "gcs.fc_limit= wsrep_slave_threads * 5";
  }
  else {
- goodprint "gcs.limit is equal to 5 * wsrep_slave_threads";
+ goodprint "gcs.fc_limit is equal to 5 * wsrep_slave_threads";
  }
  if (get_wsrep_option('gcs.fc_factor') == 0.8 ) {
  badprint "gcs.fc_factor should be equal to 0.8";
  push @adjvars, "gcs.fc_factor=0.8";
  }
  else {
- goodprint "gcs.limit is equal to 5 * wsrep_slave_threads";
+ goodprint "gcs.fc_limit is equal to 5 * wsrep_slave_threads";
  }
- if (get_wsrep_option('wsrep_flow_control_paused') > 0.02) {
+ if ($mystat{'wsrep_flow_control_paused'} > 0.02) {
  badprint "Fraction of time node pause flow control > 0.02";
  }
  else {