Skip to content

fix: Typo in READMe.md #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2024
Merged

fix: Typo in READMe.md #111

merged 1 commit into from
Feb 28, 2024

Conversation

@mahmudhmh
Copy link
Contributor

@mahmudhmh mahmudhmh commented Feb 23, 2024 •
edited
Loading

in the slideInLeft at Animation desk photo section was named wrong @alfredodeza
@alfredodeza
Copy link
Contributor

Hi @mahmudhmh , not sure how the slideIn was named wrong. I see you've made changes but those seemed correct from before
@mahmudhmh
Copy link
Contributor Author

In the Readme file the animate-desk-photo the new animation is named slideInLeft in style.css. But it is later referenced as slideIn, which could be a typo.
@alfredodeza
Copy link
Contributor

Thanks for pointing it out! I totally missed where the change was coming from. Thanks so much!
@alfredodeza alfredodeza merged commit 504630e into github-education-resources:main Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@mahmudhmh @alfredodeza