Skip to content

Commit 1e02677

Browse files
eneufeldsdirix
authored andcommitted
Fix dispatch call in angular master
Also remove the unnecessary service registration in angular module.
1 parent d10c445 commit 1e02677

File tree

2 files changed

+3
-6
lines changed

2 files changed

+3
-6
lines changed

packages/angular-material/src/other/master-detail/master.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -159,9 +159,8 @@ export class MasterListComponent extends JsonFormsArrayControl {
159159

160160
ngOnInit() {
161161
super.ngOnInit();
162-
const { addItem, removeItems } = mapDispatchToArrayControlProps(
163-
this.jsonFormsService.updateCore
164-
);
162+
const dispatch = this.jsonFormsService.updateCore.bind(this.jsonFormsService);
163+
const { addItem, removeItems } = mapDispatchToArrayControlProps(dispatch);
165164
this.addItem = addItem;
166165
this.removeItems = removeItems;
167166
}

packages/angular/src/jsonforms.module.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,9 @@ import { NgModule } from '@angular/core';
2626

2727
import { JsonFormsOutlet } from './jsonforms.component';
2828
import { UnknownRenderer } from './unknown.component';
29-
import { JsonFormsAngularService } from './jsonforms.service';
3029
@NgModule({
3130
declarations: [JsonFormsOutlet, UnknownRenderer],
3231
entryComponents: [UnknownRenderer],
33-
exports: [JsonFormsOutlet],
34-
providers: [JsonFormsAngularService]
32+
exports: [JsonFormsOutlet]
3533
})
3634
export class JsonFormsModule {}

0 commit comments

Comments
 (0)