Small arithmetic simplification #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Owner
| I don't disagree stylistically, but these changes do add about 5% to the benchmark times on my machine, which isn't ideal. |
Contributor Author
| That is strange, but looks like it's second commit causes slowdown, first actually gives ~5% speedup |
Owner
| Yup, first commit on its own seems to give a (marginal) speed-up. I think that makes sense; Push the branch back to just the first commit and I'll merge this. |
Contributor Author
| @eapache done |
eapache added a commit that referenced this pull request Jun 6, 2015
Small arithmetic simplification
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
IMO this reads nicer, and it's easier to understand :)