v0.3 release #98
Merged
v0.3 release #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
darbio reviewed Dec 13, 2020
Contributor
darbio left a comment
darbio left a comment There was a problem hiding this comment.
Looks great. Thanks for all of your hard work. Added a few comments - mainly just so I can understand how the lib works than changes that need to be made. Awesome effort!
| const conditonError = (op) => | ||
| error(`You can only supply one sortKey condition per query. Already using '${op}'`) | ||
| import { error, conditonError } from '../lib/utils' | ||
| import { Document } from 'aws-sdk/clients/textract' |
Contributor
There was a problem hiding this comment.
AWS SDK is not a dependency in your package.json (it's a dev dependency).
Do you want it to be a dependency seeing as you reference it here?
| "aws-sdk": "^2.713.0", | ||
| "@types/jest": "^26.0.14", | ||
| "@types/node": "^14.11.2", | ||
| "aws-sdk": "^2.763.0", |
Contributor
There was a problem hiding this comment.
Should this be in dependencies? Not dev dependencies.
| // Merge and return parsed attribute | ||
| return Object.assign(acc,parseAttributeConfig(field ,{ type: attrs[field] } as TableAttributeConfig)) | ||
| } else { | ||
| // TODO: Is there a better way to do this without casting this value? |
Contributor
There was a problem hiding this comment.
If you do an else if and make the comparator instanceof this would be "better" (though it doesn't really matter to the built fist)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.