Tweaks for gather (microsoft#10532)

FileSystem - raw tests have some failures, but these are currently known to be flakey and the changes in this PR have no bearing on them.

Author: greazer

build/webpack/webpack.extension.config.js

@@ -61,7 +61,7 @@ const config = {
  },
  // Packages listed in externals keeps webpack from trying to package them.
  // The ppaPackageList variable is set to non-empty if the build pipeline has been
- //authenticated to install @msrvida/python-program-analysis.
+ // authenticated to install @msrvida/python-program-analysis.
  externals: ['vscode', 'commonjs', ...ppaPackageList, ...existingModulesInOutDir],
  plugins: [
  ...common.getDefaultPlugins('extension'),

package.json

@@ -1863,14 +1863,14 @@
  },
  "python.dataScience.enableGather": {
  "type": "boolean",
- "default": false,
- "description": "Enable experimental code gathering for executed cells. For a gathered cell, that cell and only the code it depends on will be exported to a new notebook.",
+ "default": true,
+ "description": "Python Insiders Only: Enable experimental gather feature for executed cells. For a gathered cell, that cell and only the code it depends on will be exported to a new notebook.",
  "scope": "resource"
  },
  "python.dataScience.gatherToScript": {
  "type": "boolean",
- "default": true,
- "description": "If experimental code gather is enabled, gather code to a python script rather than a notebook.",
+ "default": false,
+ "description": "Python Insiders Only: If experimental gather feature is enabled, gather code to a python script rather than a notebook.",
  "scope": "resource"
  },
  "python.dataScience.codeLenses": {

src/client/datascience/gather/gather.ts

@@ -25,6 +25,7 @@ export class GatherProvider implements IGatherProvider {
  @inject(IDisposableRegistry) private disposables: IDisposableRegistry,
  @inject(ICommandManager) private commandManager: ICommandManager
  ) {
+ // Disable gather if we're not running on insiders.
  this._enabled =
  this.configService.getSettings().datascience.enableGather &&
  this.configService.getSettings().insidersChannel !== 'off'