Skip to content
This repository was archived by the owner on Aug 29, 2021. It is now read-only.

Commit c96b93f

Browse files
committed
Move from *_GET_PRIVATE macros to *_get_instance_private functions
Those are autodeclared `G_DEFINE_TYPE_WITH_PRIVATE` anyways, requires `glib` >= 2.38 which was released 2013-09-23.
1 parent 629c093 commit c96b93f

File tree

3 files changed

+17
-21
lines changed

3 files changed

+17
-21
lines changed

src/goat-dataset.c

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,6 @@
2424

2525
static void update_extrema_cache (GoatDataset *dataset);
2626

27-
#define GOAT_DATASET_GET_PRIVATE(object) (G_TYPE_INSTANCE_GET_PRIVATE ((object), GOAT_TYPE_DATASET, GoatDatasetPrivate))
28-
2927
struct _GoatDatasetPrivate {
3028
GList *list;
3129
gint count;
@@ -38,7 +36,7 @@ struct _GoatDatasetPrivate {
3836
GoatDatasetStyle style;
3937
};
4038

41-
G_DEFINE_TYPE (GoatDataset, goat_dataset, G_TYPE_OBJECT);
39+
G_DEFINE_TYPE_WITH_PRIVATE (GoatDataset, goat_dataset, G_TYPE_OBJECT);
4240

4341
static void goat_dataset_finalize (GObject *object)
4442
{
@@ -61,7 +59,7 @@ static GParamSpec *obj_properties[N_PROPERTIES] = {
6159
static void goat_dataset_set_gproperty (GObject *object, guint prop_id, const GValue *value, GParamSpec *spec)
6260
{
6361
GoatDataset *dataset = GOAT_DATASET (object);
64-
GoatDatasetPrivate *priv = GOAT_DATASET_GET_PRIVATE (dataset);
62+
GoatDatasetPrivate *priv = goat_dataset_get_instance_private (dataset);
6563

6664
switch (prop_id) {
6765
case PROP_COUNT:
@@ -80,7 +78,7 @@ static void goat_dataset_set_gproperty (GObject *object, guint prop_id, const GV
8078
static void goat_dataset_get_gproperty (GObject *object, guint prop_id, GValue *value, GParamSpec *spec)
8179
{
8280
GoatDataset *dataset = GOAT_DATASET (object);
83-
GoatDatasetPrivate *priv = GOAT_DATASET_GET_PRIVATE (dataset);
81+
GoatDatasetPrivate *priv = goat_dataset_get_instance_private (dataset);
8482

8583
switch (prop_id) {
8684
case PROP_COUNT:
@@ -116,7 +114,7 @@ static void goat_dataset_class_init (GoatDatasetClass *klass)
116114

117115
static void goat_dataset_init (GoatDataset *self)
118116
{
119-
self->priv = GOAT_DATASET_GET_PRIVATE (self);
117+
self->priv = goat_dataset_get_instance_private (self);
120118
self->priv->list = NULL;
121119
self->priv->count = -1;
122120
self->priv->x_min = +G_MAXDOUBLE;
@@ -300,7 +298,7 @@ void goat_dataset_set_color (GoatDataset *dataset, GdkRGBA *color)
300298
g_return_if_fail (dataset);
301299
g_return_if_fail (color);
302300

303-
priv = GOAT_DATASET_GET_PRIVATE (dataset);
301+
priv = goat_dataset_get_instance_private (dataset);
304302

305303
priv->color = *color;
306304
}
@@ -312,7 +310,7 @@ void goat_dataset_get_color (GoatDataset *dataset, GdkRGBA *color)
312310
g_return_if_fail (dataset);
313311
g_return_if_fail (color);
314312

315-
priv = GOAT_DATASET_GET_PRIVATE (dataset);
313+
priv = goat_dataset_get_instance_private (dataset);
316314

317315
*color = priv->color;
318316
}

src/goat-plot-internal.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ gboolean draw_scales (GoatPlot *plot, cairo_t *cr, GtkAllocation *allocation, Gt
3030
bottom = allocation->height - padding->bottom - padding->top;
3131
right = allocation->width - padding->right - padding->left;
3232

33-
GoatPlotPrivate *priv = GOAT_PLOT_GET_PRIVATE (plot);
33+
GoatPlotPrivate *priv = goat_plot_get_instance_private (plot);
3434

3535
g_assert (priv);
3636
g_assert (priv->scale_x);

src/goat-plot.c

Lines changed: 10 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,6 @@ static void get_prefered_height (GtkWidget *widget, int *minimal, int *natural);
3131
static gboolean event (GtkWidget *widget, GdkEvent *event);
3232
static gboolean scroll_event (GtkWidget *widget, GdkEventScroll *event);
3333

34-
#define GOAT_PLOT_GET_PRIVATE(object) (G_TYPE_INSTANCE_GET_PRIVATE ((object), GOAT_TYPE_PLOT, GoatPlotPrivate))
35-
3634
struct _GoatPlotPrivate {
3735
GArray *array; // array of GoatDataset pointers
3836
// remove this, its the users duty to prescale data properly FIXME
@@ -44,14 +42,14 @@ struct _GoatPlotPrivate {
4442
GoatScale *scale_y;
4543
};
4644

47-
G_DEFINE_TYPE (GoatPlot, goat_plot, GTK_TYPE_DRAWING_AREA);
45+
G_DEFINE_TYPE_WITH_PRIVATE (GoatPlot, goat_plot, GTK_TYPE_DRAWING_AREA);
4846

4947
#include "goat-plot-internal.h"
5048

5149
static void goat_plot_finalize (GObject *object)
5250
{
5351
GoatPlot *plot = GOAT_PLOT (object);
54-
GoatPlotPrivate *priv = GOAT_PLOT_GET_PRIVATE (plot);
52+
GoatPlotPrivate *priv = goat_plot_get_instance_private (plot);
5553
gint register i = priv->array->len;
5654
while (--i >= 0) {
5755
g_object_unref (g_array_index (priv->array, GoatDataset *, i));
@@ -77,7 +75,7 @@ static GParamSpec *obj_properties[N_PROPERTIES] = {
7775
static void goat_plot_set_gproperty (GObject *object, guint prop_id, const GValue *value, GParamSpec *spec)
7876
{
7977
GoatPlot *dataset = GOAT_PLOT (object);
80-
GoatPlotPrivate *priv = GOAT_PLOT_GET_PRIVATE (dataset);
78+
GoatPlotPrivate *priv = goat_plot_get_instance_private (dataset);
8179

8280
switch (prop_id) {
8381
case PROP_SCALE_X:
@@ -94,7 +92,7 @@ static void goat_plot_set_gproperty (GObject *object, guint prop_id, const GValu
9492
static void goat_plot_get_gproperty (GObject *object, guint prop_id, GValue *value, GParamSpec *spec)
9593
{
9694
GoatPlot *dataset = GOAT_PLOT (object);
97-
GoatPlotPrivate *priv = GOAT_PLOT_GET_PRIVATE (dataset);
95+
GoatPlotPrivate *priv = goat_plot_get_instance_private (dataset);
9896

9997
switch (prop_id) {
10098
case PROP_SCALE_X:
@@ -144,7 +142,7 @@ static void goat_plot_init (GoatPlot *self)
144142
GtkWidget *widget = GTK_WIDGET (self);
145143
gtk_widget_set_has_window (widget, FALSE);
146144

147-
self->priv = GOAT_PLOT_GET_PRIVATE (self);
145+
self->priv = goat_plot_get_instance_private (self);
148146

149147
self->priv->array = g_array_new (FALSE, TRUE, sizeof (void *));
150148

@@ -208,7 +206,7 @@ gint goat_plot_add_dataset (GoatPlot *plot, GoatDataset *dataset)
208206
GoatDataset *goat_plot_remove_dataset (GoatPlot *plot, gint datasetid)
209207
{
210208
GoatDataset *dataset = NULL;
211-
GoatPlotPrivate *priv = GOAT_PLOT_GET_PRIVATE (plot);
209+
GoatPlotPrivate *priv = goat_plot_get_instance_private (plot);
212210
GoatDataset **datasetptr = &(g_array_index (priv->array, GoatDataset *, datasetid));
213211
if (datasetptr != NULL) {
214212
dataset = *datasetptr;
@@ -254,7 +252,7 @@ static gboolean draw_dataset (GoatPlot *plot, cairo_t *cr, GoatDataset *dataset,
254252
return TRUE;
255253
}
256254

257-
GoatPlotPrivate *priv = GOAT_PLOT_GET_PRIVATE (plot);
255+
GoatPlotPrivate *priv = goat_plot_get_instance_private (plot);
258256
(void)priv;
259257

260258
gdouble x, y;
@@ -340,7 +338,7 @@ static gboolean draw (GtkWidget *widget, cairo_t *cr)
340338

341339
if (gtk_widget_is_drawable (widget)) {
342340
plot = GOAT_PLOT (widget);
343-
priv = GOAT_PLOT_GET_PRIVATE (plot);
341+
priv = goat_plot_get_instance_private (plot);
344342
cairo_save (cr);
345343

346344
gtk_widget_get_allocation (widget, &allocation);
@@ -468,7 +466,7 @@ void goat_plot_set_background_color (GoatPlot *plot, GdkRGBA *color)
468466

469467
GoatPlotPrivate *priv;
470468

471-
priv = GOAT_PLOT_GET_PRIVATE (plot);
469+
priv = goat_plot_get_instance_private (plot);
472470

473471
priv->color_background = *color;
474472
}
@@ -481,7 +479,7 @@ void goat_plot_set_border_color (GoatPlot *plot, GdkRGBA *color)
481479

482480
GoatPlotPrivate *priv;
483481

484-
priv = GOAT_PLOT_GET_PRIVATE (plot);
482+
priv = goat_plot_get_instance_private (plot);
485483

486484
priv->color_border = *color;
487485
}

0 commit comments

Comments
 (0)