Skip to content

Commit 790d69c

Browse files
authored
Merge pull request tomalaforge#696 from jdegand/bug-cd-md
docs: add note to bug-cd-md
2 parents 3aa4561 + dab5143 commit 790d69c

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

docs/src/content/docs/challenges/angular/32-bug-cd.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,10 @@ In this small application, we have a navigation menu to route our application to
2525

2626
The goal of the challenge is to debug this application and make it work.
2727

28+
:::note
29+
Without knowing the exact reason for the issue, you can "fix" the error and get the program to function. One such approach would be to memoize `getMenu`. The application might work again, but make sure you really understand the problem and its consequences. Making it work isn't always enough; fixing this bug in the wrong way can cause a loss of performance or lead to other problems later on.
30+
:::
31+
2832
## Hints
2933

3034
<details>
@@ -36,6 +40,6 @@ The goal of the challenge is to debug this application and make it work.
3640
<details>
3741
<summary>Hint 2</summary>
3842

39-
If you open the [`RouterLinkActive` source code](https://github.com/angular/angular/blob/main/packages/router/src/directives/router_link_active.ts) and go to **line 196**, Angular is calling `this.cdr.markForCheck` inside a microTask which triggers a new CD cycle. If you comment out this line, the application loads again, however the bug is not inside the Angular Framework. 😅😯
43+
If you open the [`RouterLinkActive` source code](https://github.com/angular/angular/blob/main/packages/router/src/directives/router_link_active.ts) and go to **line 196**, Angular is calling `this.cdr.markForCheck` inside a microTask, which triggers a new CD cycle. If you comment out this line, the application loads again, however, the bug should not be fixed by changing the Angular source code. 😅😯
4044

4145
</details>

0 commit comments

Comments
 (0)