Skip to content

Add WCF update extension #1237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 54 commits into from
Aug 24, 2022
Merged

Add WCF update extension #1237

merged 54 commits into from
Aug 24, 2022

Conversation

@SimonaLiao
Copy link
Contributor

Add WCF update extension
Adds a WCFUpdater extension which will automatically port WCF projects to use CoreWCF services. PR also includes unit tests for all classes and an integration test with the BeanTrader example.

PR Description
Here are most files in my extension library:

  1. SourceCodeUpdater: updates source code file such as program.cs. Deals with using directives, ServiceHost instance, and registering configuration. (Currently supports serviceMetadata and serviceDebug behaviors.)
  2. ConfigUpdater: analyzes the config file and updates it to create a new wcf.config
  3. PackageUpdater: updates the project file by changing sdk & package references
  4. UpdaterFactory: constructs the above updaters
  5. UpdateRunner: run and write all the changes

Addresses #1083
@SimonaLiao SimonaLiao requested a review from a team as a code owner July 29, 2022 22:39
@SimonaLiao SimonaLiao self-assigned this Jul 29, 2022
@dnfadmin
Copy link

dnfadmin commented Jul 29, 2022 •
edited
Loading

CLA assistant check
All CLA requirements met.
brandonh-msft
brandonh-msft suggested changes Aug 1, 2022
View reviewed changes
Copy link
Contributor

@brandonh-msft brandonh-msft left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SimonaLiao ! Can you do a round of fixes for the code/style analyzers so we can see the build go green, at least w/in your code?

Don't worry about the arcade build issue on the xunit references for now - I'll have a look into that as it doesn't appear to be related to your changes.
@brandonh-msft brandonh-msft requested a review from a team August 1, 2022 19:31
mjrousos
mjrousos previously approved these changes Aug 17, 2022
View reviewed changes
Copy link
Member

@mjrousos mjrousos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for putting this together, @SimonaLiao! I've put some comments and suggestions in-line but nothing blocking.
@brandonh-msft
Copy link
Contributor

@SimonaLiao if you have addressed any asks/comments w/in this PR, please use the Resolve Conversation button so we know what's been done and what hasn't - this will expedite re-reviews :)
brandonh-msft
brandonh-msft approved these changes Aug 24, 2022
View reviewed changes
Copy link
Contributor

@brandonh-msft brandonh-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢🎉
@SimonaLiao SimonaLiao merged commit 020e317 into dotnet:main Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

6 participants

@SimonaLiao @dnfadmin @brandonh-msft @mconnew @mjrousos @HongGit