Trim NetEventSource when EventSource.IsSupported is false (#38828)

* Trim NetEventSource when EventSource.IsSupported is false Follow up to #38129. NetEventSource code was still left in even when EventSource.IsSupported is false, since all the usages of NetEventSource are keying off its own static property: NetEventSource.IsEnabled. Remove NetEventSource.IsEnabled so the linker can trim NetEventSource code when EventSource.IsSupported is false. * Remove HttpTelemetry.IsEnabled static property so the linker can trim EventSource code when EventSource.IsSupported is false. * Fix fake NetEventSource to match what is in the product.

Author: eerhardt

src/libraries/Common/src/Interop/OSX/System.Security.Cryptography.Native.Apple/Interop.Ssl.cs

@@ -399,7 +399,7 @@ public static bool SslCheckHostnameMatch(SafeSslHandle handle, string hostName,
  case 1:
  return true;
  default:
- if (NetEventSource.IsEnabled)
+ if (NetEventSource.Log.IsEnabled())
  NetEventSource.Error(null, $"AppleCryptoNative_SslIsHostnameMatch returned '{result}' for '{hostName}'");
  Debug.Fail($"AppleCryptoNative_SslIsHostnameMatch returned {result}");
  throw new SslException();

src/libraries/Common/src/Interop/Windows/HttpApi/Interop.HttpApi.cs

@@ -663,13 +663,13 @@ internal static int IndexOfKnownHeader(string headerName)
 
  private static unsafe string GetKnownHeader(HTTP_REQUEST* request, long fixup, int headerIndex)
  {
- if (NetEventSource.IsEnabled) { NetEventSource.Enter(null); }
+ if (NetEventSource.Log.IsEnabled()) { NetEventSource.Enter(null); }
 
  string header = null;
 
  HTTP_KNOWN_HEADER* pKnownHeader = (&request->Headers.KnownHeaders) + headerIndex;
 
- if (NetEventSource.IsEnabled)
+ if (NetEventSource.Log.IsEnabled())
  {
  NetEventSource.Info(null, $"HttpApi::GetKnownHeader() pKnownHeader:0x{(IntPtr)pKnownHeader}");
  NetEventSource.Info(null, $"HttpApi::GetKnownHeader() pRawValue:0x{(IntPtr)pKnownHeader->pRawValue} RawValueLength:{pKnownHeader->RawValueLength}");
@@ -682,7 +682,7 @@ private static unsafe string GetKnownHeader(HTTP_REQUEST* request, long fixup, i
  header = new string(pKnownHeader->pRawValue + fixup, 0, pKnownHeader->RawValueLength);
  }
 
- if (NetEventSource.IsEnabled) { NetEventSource.Exit(null, $"HttpApi::GetKnownHeader() return:{header}"); }
+ if (NetEventSource.Log.IsEnabled()) { NetEventSource.Exit(null, $"HttpApi::GetKnownHeader() return:{header}"); }
  return header;
  }
 
@@ -776,7 +776,7 @@ internal static unsafe WebHeaderCollection GetHeaders(IntPtr memoryBlob, IntPtr
 
  internal static unsafe uint GetChunks(IntPtr memoryBlob, IntPtr originalAddress, ref int dataChunkIndex, ref uint dataChunkOffset, byte[] buffer, int offset, int size)
  {
- if (NetEventSource.IsEnabled)
+ if (NetEventSource.Log.IsEnabled())
  {
  NetEventSource.Enter(null, $"HttpApi::GetChunks() memoryBlob:{memoryBlob}");
  }
@@ -828,7 +828,7 @@ internal static unsafe uint GetChunks(IntPtr memoryBlob, IntPtr originalAddress,
  dataChunkIndex = -1;
  }
 
- if (NetEventSource.IsEnabled)
+ if (NetEventSource.Log.IsEnabled())
  {
  NetEventSource.Exit(null);
  }
@@ -854,7 +854,7 @@ internal static unsafe HTTP_VERB GetKnownVerb(IntPtr memoryBlob, IntPtr original
 
  internal static unsafe IPEndPoint GetRemoteEndPoint(IntPtr memoryBlob, IntPtr originalAddress)
  {
- if (NetEventSource.IsEnabled) NetEventSource.Enter(null);
+ if (NetEventSource.Log.IsEnabled()) NetEventSource.Enter(null);
 
  SocketAddress v4address = new SocketAddress(AddressFamily.InterNetwork, IPv4AddressSize);
  SocketAddress v6address = new SocketAddress(AddressFamily.InterNetworkV6, IPv6AddressSize);
@@ -874,13 +874,13 @@ internal static unsafe IPEndPoint GetRemoteEndPoint(IntPtr memoryBlob, IntPtr or
  endpoint = new IPEndPoint(IPAddress.IPv6Any, IPEndPoint.MinPort).Create(v6address) as IPEndPoint;
  }
 
- if (NetEventSource.IsEnabled) NetEventSource.Exit(null);
+ if (NetEventSource.Log.IsEnabled()) NetEventSource.Exit(null);
  return endpoint;
  }
 
  internal static unsafe IPEndPoint GetLocalEndPoint(IntPtr memoryBlob, IntPtr originalAddress)
  {
- if (NetEventSource.IsEnabled) NetEventSource.Enter(null);
+ if (NetEventSource.Log.IsEnabled()) NetEventSource.Enter(null);
 
  SocketAddress v4address = new SocketAddress(AddressFamily.InterNetwork, IPv4AddressSize);
  SocketAddress v6address = new SocketAddress(AddressFamily.InterNetworkV6, IPv6AddressSize);
@@ -900,7 +900,7 @@ internal static unsafe IPEndPoint GetLocalEndPoint(IntPtr memoryBlob, IntPtr ori
  endpoint = s_ipv6Any.Create(v6address) as IPEndPoint;
  }
 
- if (NetEventSource.IsEnabled) NetEventSource.Exit(null);
+ if (NetEventSource.Log.IsEnabled()) NetEventSource.Exit(null);
  return endpoint;
  }
 

src/libraries/Common/src/Interop/Windows/SChannel/UnmanagedCertificateContext.IntPtr.cs

@@ -40,7 +40,7 @@ internal static X509Certificate2Collection GetRemoteCertificatesFromStoreContext
  }
 
  var cert = new X509Certificate2(new IntPtr(next));
- if (NetEventSource.IsEnabled) NetEventSource.Info(certContext, $"Adding remote certificate:{cert}");
+ if (NetEventSource.Log.IsEnabled()) NetEventSource.Info(certContext, $"Adding remote certificate:{cert}");
 
  result.Add(cert);
  last = next;

src/libraries/Common/src/Interop/Windows/SspiCli/NegotiationInfoClass.cs

@@ -14,7 +14,7 @@ internal static partial class NegotiationInfoClass
  {
  if (safeHandle.IsInvalid)
  {
- if (NetEventSource.IsEnabled) NetEventSource.Info(null, $"Invalid handle:{safeHandle}");
+ if (NetEventSource.Log.IsEnabled()) NetEventSource.Info(null, $"Invalid handle:{safeHandle}");
  return null;
  }
 
@@ -23,7 +23,7 @@ internal static partial class NegotiationInfoClass
  {
  safeHandle.DangerousAddRef(ref gotRef);
  IntPtr packageInfo = safeHandle.DangerousGetHandle();
- if (NetEventSource.IsEnabled) NetEventSource.Info(null, $"packageInfo:{packageInfo} negotiationState:{negotiationState:x}");
+ if (NetEventSource.Log.IsEnabled()) NetEventSource.Info(null, $"packageInfo:{packageInfo} negotiationState:{negotiationState:x}");
 
  if (negotiationState == Interop.SspiCli.SECPKG_NEGOTIATION_COMPLETE ||
  negotiationState == Interop.SspiCli.SECPKG_NEGOTIATION_OPTIMISTIC)
@@ -34,7 +34,7 @@ internal static partial class NegotiationInfoClass
  name = Marshal.PtrToStringUni(((SecurityPackageInfo*)packageInfo)->Name);
  }
 
- if (NetEventSource.IsEnabled) NetEventSource.Info(null, $"packageInfo:{packageInfo} negotiationState:{negotiationState:x} name:{name}");
+ if (NetEventSource.Log.IsEnabled()) NetEventSource.Info(null, $"packageInfo:{packageInfo} negotiationState:{negotiationState:x} name:{name}");
 
  // An optimization for future string comparisons.
  return

src/libraries/Common/src/Interop/Windows/SspiCli/SSPIAuthType.cs

@@ -26,7 +26,7 @@ public SecurityPackageInfoClass[]? SecurityPackages
 
  public int EnumerateSecurityPackages(out int pkgnum, out SafeFreeContextBuffer pkgArray)
  {
- if (NetEventSource.IsEnabled) NetEventSource.Info(this);
+ if (NetEventSource.Log.IsEnabled()) NetEventSource.Info(this);
  return SafeFreeContextBuffer.EnumeratePackages(out pkgnum, out pkgArray);
  }
 

src/libraries/Common/src/Interop/Windows/SspiCli/SSPISecureChannelType.cs

@@ -26,7 +26,7 @@ public SecurityPackageInfoClass[]? SecurityPackages
 
  public int EnumerateSecurityPackages(out int pkgnum, out SafeFreeContextBuffer pkgArray)
  {
- if (NetEventSource.IsEnabled) NetEventSource.Info(this);
+ if (NetEventSource.Log.IsEnabled()) NetEventSource.Info(this);
  return SafeFreeContextBuffer.EnumeratePackages(out pkgnum, out pkgArray);
  }