Skip to content

Conversation

@ashbhandare
Copy link
Contributor

@ashbhandare ashbhandare commented Nov 13, 2019

This change adds a NimbusML entrypoint to the ImageClassification Trainer. It modifies the ImageLoader transform to add an option to load in-memory images. This change also adds a unit test to test the entrypoint.

@ashbhandare ashbhandare requested a review from a team as a code owner November 13, 2019 21:48
@ashbhandare ashbhandare changed the title Add Entrypoint for ImageClassification Transform. Add Entrypoint for ImageClassification Trainer. Nov 13, 2019
Copy link
Member

@codemzs codemzs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐


[assembly: InternalsVisibleTo(assemblyName: "Microsoft.ML.Tests" + PublicKey.TestValue)]
[assembly: InternalsVisibleTo(assemblyName: "Microsoft.ML.Tests" + PublicKey.TestValue)]
[assembly: InternalsVisibleTo(assemblyName: "Microsoft.ML.Core.Tests" + PublicKey.TestValue)]
Copy link
Member

@ganik ganik Nov 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[assembly: Int [](start = 0, length = 14)

Pls add visibility for DotNetBridge as well, see in others for examples #Resolved

@codecov
Copy link

codecov bot commented Nov 14, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@5910910). Click here to learn what that means.
The diff coverage is 100%.

@@ Coverage Diff @@ ## master #4476 +/- ## ========================================= Coverage ? 74.14% ========================================= Files ? 907 Lines ? 159705 Branches ? 17197 ========================================= Hits ? 118416 Misses ? 36511 Partials ? 4778
Flag Coverage Δ
#Debug 74.14% <100%> (?)
#production 69.27% <100%> (?)
#test 90.19% <100%> (?)
Impacted Files Coverage Δ
.../Microsoft.ML.Vision/ImageClassificationTrainer.cs 77.9% <100%> (ø)
src/Microsoft.ML.ImageAnalytics/ImageLoader.cs 87.73% <100%> (ø)
...crosoft.ML.Core.Tests/UnitTests/TestEntryPoints.cs 98.37% <100%> (ø)
public string ImageFolder;
}

[TlcModule.EntryPoint(Name = "Trainers.ImageClassifier",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to regenerate manifest_core.json and eplist

@codemzs codemzs closed this Dec 17, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants