Reformatting Featurization of Transform and Misc files in Transform to Width 85 #3950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
rayankrish requested review from artidoro, codemzs, natke, sayanshaw24, sierralee51 and wschin 
sierralee51 reviewed Jul 2, 2019
docs/samples/Microsoft.ML.Samples/Dynamic/Transforms/NormalizeSupervisedBinning.cs Show resolved Hide resolved
sierralee51 reviewed Jul 2, 2019
....ML.Samples/Dynamic/Transforms/TreeFeaturization/BinaryClassificationFeaturization.ttinclude Show resolved Hide resolved
sierralee51 approved these changes Jul 2, 2019
sayanshaw24 approved these changes Jul 2, 2019
Contributor
sayanshaw24 left a comment
sayanshaw24 left a comment There was a problem hiding this comment.
Looks good. Left a few comments.
| // and normalize it. | ||
| var transformPipeline = mlContext.Transforms.Concatenate("Features", | ||
| new string[] { nameof(Data.Feature1), nameof(Data.Feature2) }) | ||
| .Append(mlContext.Transforms.NormalizeMeanVariance("Features")); |
Contributor
There was a problem hiding this comment.
Extra spaces on line 26
docs/samples/Microsoft.ML.Samples/Dynamic/Transforms/CalculateFeatureContributionCalibrated.cs Show resolved Hide resolved
Dmitry-A pushed a commit to Dmitry-A/machinelearning that referenced this pull request Jul 24, 2019
…o Width 85 (dotnet#3950) * transform/treefeaturization formatted to 85 char * transform files not in folder formatted to 35 char
ghost locked as resolved and limited conversation to collaborators Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Guidelines followed:
-85 characters per line
-Use 4 spaces for indentation
-Dot and open parentheses stay on same line as function
-If not a preexisting line under line that we break, add an extra line after it
-Don't indent comments
-Don't break a comment if it represents output
-Don't break links
-If applicable, break right before $
-Keep math op together
Fix for issue #3478
*Misc. refers to those files found in the Transform directory but not in another subdirectory