Skip to content

Conversation

@codemzs
Copy link
Member

@codemzs codemzs commented Jan 24, 2019

No description provided.

Copy link
Contributor

@sharwell sharwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've used this form in the past and it causes so much noise it's just distracting. It actually used to be my preferred view, but once I switch to the simpler view the improvement was obvious. I recommend not making this change.

@codemzs
Copy link
Member Author

codemzs commented Jan 24, 2019

@sharwell Thanks for your input. Some of us actually like this format, I will take a vote on this and decide.

CC: @ViktorHofer

@codecov
Copy link

codecov bot commented Jan 24, 2019

Codecov Report

Merging #2235 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@ Coverage Diff @@ ## master #2235 +/- ## ========================================== - Coverage 71.54% 71.54% -0.01%  ========================================== Files 800 800 Lines 141847 141847 Branches 16119 16119 ========================================== - Hits 101480 101478 -2  - Misses 35916 35917 +1  - Partials 4451 4452 +1
Flag Coverage Δ
#Debug 71.54% <ø> (-0.01%) ⬇️
#production 67.83% <ø> (-0.01%) ⬇️
#test 85.73% <ø> (ø) ⬆️
Impacted Files Coverage Δ
...StandardLearners/Standard/LinearModelParameters.cs 60.63% <0%> (-0.27%) ⬇️
...soft.ML.Data/DataLoadSave/Text/TextLoaderCursor.cs 82.66% <0%> (-0.21%) ⬇️
Copy link
Contributor

@rogancarr rogancarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve the change, but don't have strong feelings about the view. 🎈

codecov.yml Outdated
comment:
layout: "diff,flags"
layout: "diff, flags, files"
behavior: default
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need the behavior: default.

@justinormont
Copy link
Contributor

Would it be possible to put the extra info in a collapsible box?

CLICK ME

Impacted Files Coverage Δ
...soft.ML.TestFramework/DataPipe/TestDataPipeBase.cs 70.05% <0%> (-0.33%) ⬇️
...soft.ML.Data/DataLoadSave/Text/TextLoaderCursor.cs 82.86% <0%> (+0.2%) ⬆️
...StandardLearners/Standard/LinearModelParameters.cs 60.9% <0%> (+0.26%) ⬆️
src/Microsoft.ML.Maml/MAML.cs 26.21% <0%> (+1.45%) ⬆️


via: https://gist.github.com/joyrexus/16041f2426450e73f5df9391f7f7ae5f
@sharwell
Copy link
Contributor

@justinormont It is not currently possible. I requested that behavior from codecov a long time back and will send them a reminder.

@TomFinley
Copy link
Contributor

TomFinley commented Jan 28, 2019

Am I the only one that can't see any information out of codecov at all? I have a spinning webpage that's been "loading" for minutes. (Then fails with a "codecov.io unexpectedly closed the connection".)

Unrelated: it seems like the codecov build is actually blocking the gate? The entire purpose of adding it as a separate build was so it would not do that.

@codemzs
Copy link
Member Author

codemzs commented Jan 28, 2019

@TomFinley link to the PR please? CodeCoverge-CI should not block the merge since it’s not the required step?

@codemzs
Copy link
Member Author

codemzs commented Feb 19, 2019

@TomFinley Below is the snapshot of the scenario where main CI has finished but code coverage CI has not and you can still merge:

image

@codemzs
Copy link
Member Author

codemzs commented Feb 20, 2019

@sharwell The PR view isn't working so it will be good to have a snapshot of what files are affected even though it won't show the whole list but it will list the top files.

@artidoro artidoro self-requested a review February 20, 2019 01:11
@codemzs codemzs merged commit 6c9a887 into dotnet:master Feb 20, 2019
@ghost ghost locked as resolved and limited conversation to collaborators Mar 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

7 participants