- Notifications
You must be signed in to change notification settings - Fork 1.9k
Enhance code coverage bot message. #2235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sharwell left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've used this form in the past and it causes so much noise it's just distracting. It actually used to be my preferred view, but once I switch to the simpler view the improvement was obvious. I recommend not making this change.
| @sharwell Thanks for your input. Some of us actually like this format, I will take a vote on this and decide. CC: @ViktorHofer |
Codecov Report
@@ Coverage Diff @@ ## master #2235 +/- ## ========================================== - Coverage 71.54% 71.54% -0.01% ========================================== Files 800 800 Lines 141847 141847 Branches 16119 16119 ========================================== - Hits 101480 101478 -2 - Misses 35916 35917 +1 - Partials 4451 4452 +1
|
rogancarr left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve the change, but don't have strong feelings about the view. 🎈
codecov.yml Outdated
| comment: | ||
| layout: "diff,flags" | ||
| layout: "diff, flags, files" | ||
| behavior: default |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need the behavior: default.
| Would it be possible to put the extra info in a collapsible box? CLICK ME
via: https://gist.github.com/joyrexus/16041f2426450e73f5df9391f7f7ae5f |
| @justinormont It is not currently possible. I requested that behavior from codecov a long time back and will send them a reminder. |
| Am I the only one that can't see any information out of codecov at all? I have a spinning webpage that's been "loading" for minutes. (Then fails with a "codecov.io unexpectedly closed the connection".) Unrelated: it seems like the codecov build is actually blocking the gate? The entire purpose of adding it as a separate build was so it would not do that. |
| @TomFinley link to the PR please? CodeCoverge-CI should not block the merge since it’s not the required step? |
| @TomFinley Below is the snapshot of the scenario where main CI has finished but code coverage CI has not and you can still merge: |
| @sharwell The PR view isn't working so it will be good to have a snapshot of what files are affected even though it won't show the whole list but it will list the top files. |

No description provided.