- Notifications
You must be signed in to change notification settings - Fork 1.9k
Closed
Labels
APIIssues pertaining the friendly APIIssues pertaining the friendly APIgood first issueGood for newcomersGood for newcomersup-for-grabsA good issue to fix if you are trying to contribute to the projectA good issue to fix if you are trying to contribute to the project
Description
Pursuant to #1090 and #1041 there was agreement that we should be able to just pass a string into a data reader that reads from streams, rather than have to muck about with the creation of this IMultiStreamSource object.
As it happens, this one request was done in two separate ways:
- ML Context to create them all #1252 where this instance method on
TextLoaderwas created:
| public IDataView Read(string path) => Read(new MultiFileSource(path)); |
- Extension on IDataReader<IMultiStreamSource>, and DataReader<IMultiStreamSource, TShape> to read from one or several file paths, rather than requiring constructing an IMultiStreamSource #1281 where an extension method on top of
IDataReader<IMultiStreamSource>was introduced.
Clearly we don't need both, and the second being more flexible and more broadly applicable was the one that should be checked in, so let us remove the class specific method introduced in #1252. The extension method should however be moved to a namespace where it is more likely to be picked up (probably Microsoft.ML) since right now it's a bit buried and generally people would never see this extension method.
Metadata
Metadata
Assignees
Labels
APIIssues pertaining the friendly APIIssues pertaining the friendly APIgood first issueGood for newcomersGood for newcomersup-for-grabsA good issue to fix if you are trying to contribute to the projectA good issue to fix if you are trying to contribute to the project