- Notifications
You must be signed in to change notification settings - Fork 1.9k
Closed
Labels
questionFurther information is requestedFurther information is requested
Description
Coming from #166.
- The various random number generators are not thread safe. It might make sense to make them such. Are there cases against not making them such?
- Should the generators be seeded with cryptographic random seed to make sure they're random when no seed is given?
- The MachineLearning.Net has tendency to put many classes in one file (and have them uncommented). Would there be opposition to put the classes into separate files?
- The library has also a tendency to put functions not strictly needed for the functionality in the domain classes. Such as saving, like at . Would there be opposition to provide these as extension methods or in some other fashion? Since it might be one might want to serialize things differently and organizing differently would avoid baking in dependencies. A related idea: IFormatProvider in TextLoader #126 (comment).
public void Save(BinaryWriter writer)
At a glance point, there can be other issues too. Would there be opposition to refactor points 1 through 3? Possibly 4?
Metadata
Metadata
Assignees
Labels
questionFurther information is requestedFurther information is requested