Skip to content

API documentation for DbDataSource #8311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 17, 2022
Merged

API documentation for DbDataSource #8311

merged 2 commits into from
Aug 17, 2022

Conversation

@roji
Copy link
Member

@roji roji commented Aug 16, 2022

@ghost ghost assigned roji Aug 16, 2022
@ghost ghost added the area-System.Data Data APIs (ADO.NET, XML, etc). label Aug 16, 2022
@ghost
Copy link

ghost commented Aug 16, 2022

Tagging subscribers to this area: @roji, @ajcvickers
See info in area-owners.md if you want to be subscribed.

Issue Details

Closes dotnet/runtime#73722

Author: roji
Assignees: roji
Labels:

area-System.Data
Milestone: -
@roji roji mentioned this pull request Aug 16, 2022
Closed
@opbld30

This comment was marked as outdated.

Sign in to view
@opbld34

This comment was marked as outdated.

Sign in to view
@opbld30
Copy link

opbld30 commented Aug 16, 2022

Docs Build status updates of commit 0f152cf:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Data.Common/DbDataSource.xml ✅Succeeded View
xml/System.Data.Common/DbProviderFactory.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:
@carlossanlop carlossanlop requested review from gewarren and removed request for gewarren August 16, 2022 16:21
David-Engel
David-Engel reviewed Aug 16, 2022
View reviewed changes
@roji @David-Engel
Update xml/System.Data.Common/DbDataSource.xml
f2d502d 
Co-authored-by: David Engel <dengel1012@gmail.com>
@opbld32
Copy link

opbld32 commented Aug 16, 2022

Docs Build status updates of commit f2d502d:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Data.Common/DbDataSource.xml ✅Succeeded View
xml/System.Data.Common/DbProviderFactory.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:
David-Engel
David-Engel approved these changes Aug 16, 2022
View reviewed changes
Copy link
Contributor

@David-Engel David-Engel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@roji roji merged commit 6a9539f into dotnet:main Aug 17, 2022
@roji roji deleted the DbDataSource branch August 17, 2022 11:48
bgrainger
bgrainger reviewed Aug 19, 2022
View reviewed changes
xml/System.Data.Common/DbDataSource.xml
<summary>To be added.</summary>
<returns>To be added.</returns>
<remarks>To be added.</remarks>
<summary>Returns a <see cref="T:System.Data.Common.DbBatch" /> that's ready for execution against the <see cref="T:System.Data.Common.DbDataSource" />.</summary>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The descriptions for <Member MemberName="CreateConnection"> and <Member MemberName="CreateDbBatch"> are switched in this file.

Fix: #8319
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-System.Data Data APIs (ADO.NET, XML, etc).

7 participants

@roji @opbld30 @opbld34 @opbld32 @bgrainger @ajcvickers @David-Engel