Skip to content

Conversation

@BillWagner
Copy link
Member

No description provided.

shdvr and others added 15 commits March 8, 2021 09:38
Added examples to clarify when a file extension might be limited to three characters (issue #3579).
The following sentence: > ...methods of the `Span<T>` **class**... Uses the word `class` to refer to the `Span<T>` type which is in fact a (ref) `struct`. I have changed it to read as follows: > ...methods of the `Span<T>` **type**...
The sentence: > ...each of which sleeps for an interval determine by a random number generator. Should read: > ...each of which sleeps for an interval determined by a random number generator.
* Update Path.xml - added additional information about the default path /tmp/ for Linux - fixes #5340 * Apply suggestions from code review Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
* Fix typo in Task.xml The sentence: > ...the app may terminate before any the task actually begins execution... Should read: > ...the app may terminate before the task actually begins execution... * Apply suggestions from code review Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
* Better cover File.Move across disk volumes. Currently the documentation claims that IOException is only thrown if `destFileName` exists. This is not true - moving across disk volumes involves copying and opens various IOException possibilities, e.g. "no space left on device". * Apply suggestions from code review Co-authored-by: Konstantin Gukov <kgukov@microsoft.com> Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
…4397) (#4576) * Add note about ValueTask and ValueTask<TResult> default constructors (#4397) * Apply suggestions from code review Co-authored-by: glihm <glihm@outlook.fr> Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>
In `TryParse`, `string value` was correctly updated to `string? value`, but `out bool result` was incorrectly updated to `out bool? result`.
may be is typos
single Can be converted without data loss to double
The sentence: > Represents an Accept-Encoding header **value.with** optional quality factor. Should have a space rather than dot between the words ""value with** and thus read: > Represents an Accept-Encoding header **value with** optional quality factor.
The sentence: > This method is called by the system one of the HttpClient.SendAsync methods is called. Should read: > This method is called by the system when one of the HttpClient.SendAsync methods is called.
@opbld34
Copy link

opbld34 commented Mar 9, 2021

Docs Build status updates of commit d4ed0e0:

⚠️ Validation status: warnings

File Status Preview URL Details
xml/Microsoft.Extensions.FileSystemGlobbing/FilePatternMatch.xml ⚠️Warning View Details
xml/System.IO/File.xml ✅Succeeded View
xml/System.IO/Path.xml ✅Succeeded View
xml/System.Net.Http.Headers/TransferCodingWithQualityHeaderValue.xml ✅Succeeded View
xml/System.Net.Http/HttpClient.xml ✅Succeeded View
xml/System.Net.Http/HttpMessageHandler.xml ✅Succeeded View
xml/System.Threading.Tasks/Task.xml ✅Succeeded View
xml/System.Threading.Tasks/ValueTask.xml ✅Succeeded View
xml/System.Threading.Tasks/ValueTask`1.xml ✅Succeeded View
xml/System/Boolean.xml ✅Succeeded View
xml/System/Double.xml ✅Succeeded View
xml/System/MemoryExtensions.xml ✅Succeeded View
xml/System/Span`1.xml ✅Succeeded View

xml/Microsoft.Extensions.FileSystemGlobbing/FilePatternMatch.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Stem'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Path'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Stem'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Path'.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link
Member

@ManickaP ManickaP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HttpClient and HttpMessageHandler content-wise LGTM.

Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @BillWagner

@BillWagner
Copy link
Member Author

closing and opening for a fresh build.

@BillWagner BillWagner closed this Mar 9, 2021
@BillWagner BillWagner reopened this Mar 9, 2021
@opbld34
Copy link

opbld34 commented Mar 9, 2021

Docs Build status updates of commit c39d544:

⚠️ Validation status: warnings

File Status Preview URL Details
xml/Microsoft.Extensions.FileSystemGlobbing/FilePatternMatch.xml ⚠️Warning View Details
.github/workflows/version-sweep.yml ✅Succeeded
xml/System.IO/File.xml ✅Succeeded View
xml/System.IO/Path.xml ✅Succeeded View
xml/System.Net.Http.Headers/TransferCodingWithQualityHeaderValue.xml ✅Succeeded View
xml/System.Net.Http/HttpClient.xml ✅Succeeded View
xml/System.Net.Http/HttpMessageHandler.xml ✅Succeeded View
xml/System.Threading.Tasks/Task.xml ✅Succeeded View
xml/System.Threading.Tasks/ValueTask.xml ✅Succeeded View
xml/System.Threading.Tasks/ValueTask`1.xml ✅Succeeded View
xml/System/Boolean.xml ✅Succeeded View
xml/System/Double.xml ✅Succeeded View
xml/System/MemoryExtensions.xml ✅Succeeded View
xml/System/Span`1.xml ✅Succeeded View

xml/Microsoft.Extensions.FileSystemGlobbing/FilePatternMatch.xml

  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Stem'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Path'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Stem'.
  • Line 0, Column 0: [Warning-xref-not-found] Cross reference not found: 'Path'.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@BillWagner BillWagner merged commit 539e634 into live Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet