Skip to content

Commit 559ada6

Browse files
authored
Add a note about when to validate ping payloads (#57795)
Specifically, it will probably be important for #53657.
1 parent d7101a3 commit 559ada6

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

src/Servers/Kestrel/Core/src/Internal/Http2/Http2Connection.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1086,6 +1086,8 @@ private Task ProcessPingFrameAsync(in ReadOnlySequence<byte> payload)
10861086
if (_incomingFrame.PingAck)
10871087
{
10881088
// TODO: verify that payload is equal to the outgoing PING frame
1089+
// This will be particularly important if we implement dynamic window sizing
1090+
// (https://github.com/dotnet/aspnetcore/issues/53657).
10891091
return Task.CompletedTask;
10901092
}
10911093

0 commit comments

Comments
 (0)