refactor: use references and avoid copies

Author: domferr

include/process/base_process.hpp

@@ -62,7 +62,8 @@ void process_body(std::string &node_ser, int read_fd, int send_fd, bool isMultiO
  return (PyObject*) NULL;
  }
  } else {
- int err = messaging.call_remote(response, "ff_send_out_to", index, pickl.pickle(pydata));
+ auto data = pickl.pickle(pydata);
+ int err = messaging.call_remote(response, "ff_send_out_to", index, data);
  if (PyErr_Occurred()) return (PyObject*) NULL;
  if (err <= 0) {
  PyErr_SetString(PyExc_Exception, "Error occurred sending ff_send_out_to request");
@@ -129,7 +130,8 @@ void process_body(std::string &node_ser, int read_fd, int send_fd, bool isMultiO
  err = messaging.send_response(ff::FF_GO_ON);
  } else {
  // send serialized response
- err = messaging.send_response(pickl.pickle(py_result));
+ auto resp = pickl.pickle(py_result);
+ err = messaging.send_response(resp);
  CHECK_ERROR_THEN("[child] pickle result failure: ", cleanup_exit();)
  Py_DECREF(py_result);
  }

include/process/messaging.hpp

@@ -59,18 +59,18 @@ class Messaging {
  }
 
  template<typename... Args>
- inline int send_response(Args... args) {
+ inline int send_response(Args&... args) {
  return send_message(MESSAGE_TYPE_RESPONSE, "", args...);
  }
 
  template<typename... Args>
- int call_remote(Message &response, const char* fname, Args... args) {
+ int call_remote(Message &response, const char* fname, Args&... args) {
  start_call_remote(fname, args...);
  return recv_message(response);
  }
 
  template<typename... Args>
- inline int start_call_remote(const char* fname, Args... args) {
+ inline int start_call_remote(const char* fname, Args&... args) {
  return send_message(MESSAGE_TYPE_REMOTE_PROCEDURE_CALL, fname, args...);
  }
 
@@ -162,7 +162,7 @@ class Messaging {
  }
 
  template<typename... Args>
- int send_message(message_type type, std::string f_name, Args... args) {
+ int send_message(message_type type, std::string f_name, Args&... args) {
  std::vector<std::string> serialized_args = { serialize(args)... };
 
  // send type